drm/rockchip: vop2: initialize possible_crtcs properly
authorMichael Riesch <michael.riesch@wolfvision.net>
Tue, 24 Jan 2023 05:47:01 +0000 (06:47 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Sun, 5 Feb 2023 14:21:34 +0000 (15:21 +0100)
The variable possible_crtcs is only initialized for primary and
overlay planes. Since the VOP2 driver only supports these plane
types at the moment, the current code is safe. However, in order
to provide a future-proof solution, fix the initialization of
the variable.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230124054706.3921383-2-michael.riesch@wolfvision.net
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c

index ba3b817895091fc285c965c518ad3ed614d6ad53..c59d3835971b4ab666b9cc4665d4b4094af06d05 100644 (file)
@@ -2321,10 +2321,11 @@ static int vop2_create_crtc(struct vop2 *vop2)
                                /* change the unused primary window to overlay window */
                                win->type = DRM_PLANE_TYPE_OVERLAY;
                        }
-               }
-
-               if (win->type == DRM_PLANE_TYPE_OVERLAY)
+               } else if (win->type == DRM_PLANE_TYPE_OVERLAY) {
                        possible_crtcs = (1 << nvps) - 1;
+               } else {
+                       possible_crtcs = 0;
+               }
 
                ret = vop2_plane_init(vop2, win, possible_crtcs);
                if (ret) {