ASoC: sun4i-i2s: drop unneeded snd_soc_dai_set_drvdata
authorJulia Lawall <Julia.Lawall@inria.fr>
Sat, 13 Feb 2021 10:19:06 +0000 (11:19 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:07:07 +0000 (13:07 +0000)
snd_soc_dai_set_drvdata is not needed when the set data comes from
snd_soc_dai_get_drvdata or dev_get_drvdata.  The problem was fixed
usingthe following semantic patch: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,y,e;
@@
x = dev_get_drvdata(y->dev)
... when != x = e
- snd_soc_dai_set_drvdata(y,x);

@@
expression x,y,e;
@@
x = snd_soc_dai_get_drvdata(y)
... when != x = e
- snd_soc_dai_set_drvdata(y,x);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Link: https://lore.kernel.org/r/20210213101907.1318496-4-Julia.Lawall@inria.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sunxi/sun4i-i2s.c

index 78506c3..c57feae 100644 (file)
@@ -1079,8 +1079,6 @@ static int sun4i_i2s_dai_probe(struct snd_soc_dai *dai)
                                  &i2s->playback_dma_data,
                                  &i2s->capture_dma_data);
 
-       snd_soc_dai_set_drvdata(dai, i2s);
-
        return 0;
 }