Fix test harness to correctly split extra flags.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/12094032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13539 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/test/cctest/testcfg.py b/test/cctest/testcfg.py
index 7bcccfa..86dc740 100644 (file)
--- a/test/cctest/testcfg.py
+++ b/test/cctest/testcfg.py
@@ -49,9 +49,8 @@ class CcTestSuite(testsuite.TestSuite):
     if utils.IsWindows():
       shell += ".exe"
     output = commands.Execute(context.command_prefix +
-                              [shell,
-                               "--list",
-                               context.extra_flags])
+                              [shell, "--list"] +
+                              context.extra_flags)
     if output.exit_code != 0:
       print output.stdout
       print output.stderr

diff --git a/tools/run-tests.py b/tools/run-tests.py
index c2c43a9..292f6f6 100755 (executable)
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -178,6 +178,7 @@ def ProcessOptions(options):
           "running tests locally.")
     options.no_network = True
   options.command_prefix = shlex.split(options.command_prefix)
+  options.extra_flags = shlex.split(options.extra_flags)
   if options.j == 0:
     options.j = multiprocessing.cpu_count()
   if options.no_stress:

diff --git a/tools/testrunner/local/execution.py b/tools/testrunner/local/execution.py
index 9ca3991..0f52616 100644 (file)
--- a/tools/testrunner/local/execution.py
+++ b/tools/testrunner/local/execution.py
@@ -171,7 +171,7 @@ class Runner(object):
            [os.path.abspath(os.path.join(self.context.shell_dir, shell))] +
            d8testflag +
            test.suite.GetFlagsForTestCase(test, self.context) +
-           [self.context.extra_flags])
+           self.context.extra_flags)
     return cmd