ASoC: sun4i-spdif: Handle return value of clk_prepare_enable.
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Tue, 25 Jul 2017 10:15:18 +0000 (15:45 +0530)
committerMark Brown <broonie@kernel.org>
Wed, 26 Jul 2017 12:01:33 +0000 (13:01 +0100)
clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sunxi/sun4i-spdif.c

index c49f375..b4af4aa 100644 (file)
@@ -458,11 +458,16 @@ static int sun4i_spdif_runtime_suspend(struct device *dev)
 static int sun4i_spdif_runtime_resume(struct device *dev)
 {
        struct sun4i_spdif_dev *host  = dev_get_drvdata(dev);
+       int ret;
 
-       clk_prepare_enable(host->spdif_clk);
-       clk_prepare_enable(host->apb_clk);
+       ret = clk_prepare_enable(host->spdif_clk);
+       if (ret)
+               return ret;
+       ret = clk_prepare_enable(host->apb_clk);
+       if (ret)
+               clk_disable_unprepare(host->spdif_clk);
 
-       return 0;
+       return ret;
 }
 
 static int sun4i_spdif_probe(struct platform_device *pdev)