net: phy: nxp-tja11xx: use devm_hwmon_sanitize_name()
authorMichael Walle <michael@walle.cc>
Wed, 22 Jun 2022 12:35:43 +0000 (14:35 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 24 Jun 2022 03:52:19 +0000 (20:52 -0700)
Instead of open-coding the bad characters replacement in the hwmon name,
use the new devm_hwmon_sanitize_name().

Signed-off-by: Michael Walle <michael@walle.cc>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/nxp-tja11xx.c

index 9944cc5..2a8195c 100644 (file)
@@ -444,15 +444,10 @@ static int tja11xx_hwmon_register(struct phy_device *phydev,
                                  struct tja11xx_priv *priv)
 {
        struct device *dev = &phydev->mdio.dev;
-       int i;
-
-       priv->hwmon_name = devm_kstrdup(dev, dev_name(dev), GFP_KERNEL);
-       if (!priv->hwmon_name)
-               return -ENOMEM;
 
-       for (i = 0; priv->hwmon_name[i]; i++)
-               if (hwmon_is_bad_char(priv->hwmon_name[i]))
-                       priv->hwmon_name[i] = '_';
+       priv->hwmon_name = devm_hwmon_sanitize_name(dev, dev_name(dev));
+       if (IS_ERR(priv->hwmon_name))
+               return PTR_ERR(priv->hwmon_name);
 
        priv->hwmon_dev =
                devm_hwmon_device_register_with_info(dev, priv->hwmon_name,