RDMA/hns: Do not overwrite the error code during error unwind in hns_roce_init
authorLijun Ou <oulijun@huawei.com>
Wed, 25 Jul 2018 07:29:31 +0000 (15:29 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 26 Jul 2018 22:48:48 +0000 (16:48 -0600)
When init cmq fail in initial flow of RoCE, it should return the errno of
cmq_init function, not of the rest call.

Signed-off-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_main.c

index 850032d..3ea2182 100644 (file)
@@ -886,8 +886,7 @@ error_failed_cmd_init:
 
 error_failed_cmq_init:
        if (hr_dev->hw->reset) {
-               ret = hr_dev->hw->reset(hr_dev, false);
-               if (ret)
+               if (hr_dev->hw->reset(hr_dev, false))
                        dev_err(dev, "Dereset RoCE engine failed!\n");
        }