mbr: Correct verification check
authorSimon Glass <sjg@chromium.org>
Sat, 23 Oct 2021 23:26:01 +0000 (17:26 -0600)
committerSimon Glass <sjg@chromium.org>
Sun, 28 Nov 2021 23:51:51 +0000 (16:51 -0700)
At present this command considers the partitions to be identical if the
start and size are smaller than expected. It should check that they are
the same. Fix this and tidy up the code style a little.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
cmd/mbr.c

index e7e2298..c269833 100644 (file)
--- a/cmd/mbr.c
+++ b/cmd/mbr.c
@@ -244,12 +244,12 @@ static int do_verify_mbr(struct blk_desc *dev, const char *str)
        for (i = 0; i < count; i++) {
                struct disk_partition p;
 
-               if (part_get_info(dev, i+1, &p))
+               if (part_get_info(dev, i + 1, &p))
                        goto fail;
 
-               if ((partitions[i].size && p.size < partitions[i].size) ||
-                   (partitions[i].start && p.start < partitions[i].start) ||
-                   (p.sys_ind != partitions[i].sys_ind))
+               if ((partitions[i].size && p.size != partitions[i].size) ||
+                   (partitions[i].start && p.start != partitions[i].start) ||
+                   p.sys_ind != partitions[i].sys_ind)
                        goto fail;
        }
        ret = 0;