udf: remove ->writepage
authorChristoph Hellwig <hch@lst.de>
Sun, 13 Nov 2022 16:29:02 +0000 (17:29 +0100)
committerJan Kara <jack@suse.cz>
Mon, 21 Nov 2022 10:05:01 +0000 (11:05 +0100)
->writepage is a very inefficient method to write back data, and only
used through write_cache_pages or as a fallback when no ->migrate_folio
method is present.

Set ->migrate_folio to the generic buffer_head based helper, and remove
the ->writepage implementation in extfat.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/udf/inode.c

index dce6ae9..0246b1b 100644 (file)
@@ -182,11 +182,6 @@ static void udf_write_failed(struct address_space *mapping, loff_t to)
        }
 }
 
-static int udf_writepage(struct page *page, struct writeback_control *wbc)
-{
-       return block_write_full_page(page, udf_get_block, wbc);
-}
-
 static int udf_writepages(struct address_space *mapping,
                        struct writeback_control *wbc)
 {
@@ -239,12 +234,12 @@ const struct address_space_operations udf_aops = {
        .invalidate_folio = block_invalidate_folio,
        .read_folio     = udf_read_folio,
        .readahead      = udf_readahead,
-       .writepage      = udf_writepage,
        .writepages     = udf_writepages,
        .write_begin    = udf_write_begin,
        .write_end      = generic_write_end,
        .direct_IO      = udf_direct_IO,
        .bmap           = udf_bmap,
+       .migrate_folio  = buffer_migrate_folio,
 };
 
 /*