clk: si5351: Use managed `of_clk_add_hw_provider()`
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 10 Apr 2023 01:45:01 +0000 (18:45 -0700)
committerStephen Boyd <sboyd@kernel.org>
Mon, 10 Apr 2023 19:56:25 +0000 (12:56 -0700)
Use the managed `devm_of_clk_add_hw_provider()` instead of
`of_clk_add_hw_provider()`.

This makes sure the provider gets automatically removed on unbind and
allows to completely eliminate the drivers `remove()` callback.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20230410014502.27929-10-lars@metafoo.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk-si5351.c

index 9e939c9..4fcf705 100644 (file)
@@ -1641,8 +1641,8 @@ static int si5351_i2c_probe(struct i2c_client *client)
                }
        }
 
-       ret = of_clk_add_hw_provider(client->dev.of_node, si53351_of_clk_get,
-                                    drvdata);
+       ret = devm_of_clk_add_hw_provider(&client->dev, si53351_of_clk_get,
+                                         drvdata);
        if (ret) {
                dev_err(&client->dev, "unable to add clk provider\n");
                return ret;
@@ -1651,18 +1651,12 @@ static int si5351_i2c_probe(struct i2c_client *client)
        return 0;
 }
 
-static void si5351_i2c_remove(struct i2c_client *client)
-{
-       of_clk_del_provider(client->dev.of_node);
-}
-
 static struct i2c_driver si5351_driver = {
        .driver = {
                .name = "si5351",
                .of_match_table = of_match_ptr(si5351_dt_ids),
        },
        .probe_new = si5351_i2c_probe,
-       .remove = si5351_i2c_remove,
        .id_table = si5351_i2c_ids,
 };
 module_i2c_driver(si5351_driver);