media: mtk-vpu: Remove redundant 'flush_workqueue()' calls
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 14 Oct 2021 18:21:43 +0000 (19:21 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 15 Nov 2021 08:12:07 +0000 (08:12 +0000)
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
-  flush_workqueue(E);
destroy_workqueue(E);

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/mtk-vpu/mtk_vpu.c

index 7f1647d..7bd715f 100644 (file)
@@ -964,10 +964,8 @@ static int mtk_vpu_remove(struct platform_device *pdev)
 #ifdef CONFIG_DEBUG_FS
        debugfs_remove(vpu_debugfs);
 #endif
-       if (vpu->wdt.wq) {
-               flush_workqueue(vpu->wdt.wq);
+       if (vpu->wdt.wq)
                destroy_workqueue(vpu->wdt.wq);
-       }
        vpu_free_ext_mem(vpu, P_FW);
        vpu_free_ext_mem(vpu, D_FW);
        mutex_destroy(&vpu->vpu_mutex);