net: ieee802154: atusb: Call _xmit_hw_error() upon transmission error
authorMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 7 Apr 2022 10:09:01 +0000 (12:09 +0200)
committerStefan Schmidt <stefan@datenfreihafen.org>
Mon, 25 Apr 2022 18:52:22 +0000 (20:52 +0200)
ieee802154_xmit_hw_error() is the right helper to call when a transmission
has failed for a non-determined (and probably not IEEE802.15.4 specific)
reason. Let's use this helper instead of open-coding it.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20220407100903.1695973-9-miquel.raynal@bootlin.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
drivers/net/ieee802154/atusb.c

index 9b41c76..2c33878 100644 (file)
@@ -206,9 +206,7 @@ static void atusb_tx_done(struct atusb *atusb, u8 seq)
                 * unlikely case now that seq == expect is then true, but can
                 * happen and fail with a tx_skb = NULL;
                 */
-               ieee802154_wake_queue(atusb->hw);
-               if (atusb->tx_skb)
-                       dev_kfree_skb_irq(atusb->tx_skb);
+               ieee802154_xmit_hw_error(atusb->hw, atusb->tx_skb);
        }
 }