hwmon: (pmbus) Clear pmbus fault/warning bits after read
authorVikash Chandola <vikash.chandola@linux.intel.com>
Tue, 22 Feb 2022 13:12:53 +0000 (13:12 +0000)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 22 Feb 2022 16:15:39 +0000 (08:15 -0800)
Almost all fault/warning bits in pmbus status registers remain set even
after fault/warning condition are removed. As per pmbus specification
these faults must be cleared by user.
Modify hwmon behavior to clear fault/warning bit after fetching data if
fault/warning bit was set. This allows to get fresh data in next read.

Signed-off-by: Vikash Chandola <vikash.chandola@linux.intel.com>
Link: https://lore.kernel.org/r/20220222131253.2426834-1-vikash.chandola@linux.intel.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/pmbus/pmbus_core.c

index 776ee2237be20ad7c0af6b8b16d335d82cdf67eb..ac2fbee1ba9c0dbd5ed65e0a17636ab58a19c9b7 100644 (file)
@@ -911,6 +911,11 @@ static int pmbus_get_boolean(struct i2c_client *client, struct pmbus_boolean *b,
                pmbus_update_sensor_data(client, s2);
 
        regval = status & mask;
+       if (regval) {
+               ret = pmbus_write_byte_data(client, page, reg, regval);
+               if (ret)
+                       goto unlock;
+       }
        if (s1 && s2) {
                s64 v1, v2;