scsi: isci: remove redundant check on in_connection_align_insertion_frequency

The sanity check on u->in_connection_align_insertion_frequency is being
performed twice and hence the first check can be removed since it is
redundant. Cleans up cppcheck warning:

drivers/scsi/ibmvscsi/ibmvscsi.c:1711: (warning) Identical inner 'if'
condition is always true.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
index 922e3e5..05cf4da 100644 (file)
--- a/drivers/scsi/isci/init.c
+++ b/drivers/scsi/isci/init.c
@@ -433,9 +433,6 @@ static enum sci_status sci_user_parameters_set(struct isci_host *ihost,
                      (u->max_speed_generation > SCIC_SDS_PARM_NO_SPEED)))
                        return SCI_FAILURE_INVALID_PARAMETER_VALUE;
 
-               if (u->in_connection_align_insertion_frequency < 3)
-                       return SCI_FAILURE_INVALID_PARAMETER_VALUE;
-
                if ((u->in_connection_align_insertion_frequency < 3) ||
                    (u->align_insertion_frequency == 0) ||
                    (u->notify_enable_spin_up_insertion_frequency == 0))