clk: agilex: Handle clock configuration differently in SPL and U-Boot proper
authorChee Hong Ang <chee.hong.ang@intel.com>
Fri, 10 Jul 2020 12:55:22 +0000 (20:55 +0800)
committerLey Foon Tan <ley.foon.tan@intel.com>
Fri, 9 Oct 2020 09:53:10 +0000 (17:53 +0800)
Since warm reset may optionally set the CLock Manager to'boot mode',
the clock driver should always force the Agilex's Clock Manager to
'boot mode' before the clock driver start configuring the Clock Manager
in SPL.
In SSBL, clock driver will skip the Clock Manager configuration
if it's already being setup by SPL (Clock Manager NOT in 'boot
mode') to prevent any inaccurate clocking issues happened on HPS
peripherals such as UART, MAC and etc.

Signed-off-by: Chee Hong Ang <chee.hong.ang@intel.com>
drivers/clk/altera/clk-agilex.c

index 36a224d..fc4d239 100644 (file)
@@ -171,6 +171,16 @@ static void clk_basic_init(struct udevice *dev,
        if (!cfg)
                return;
 
+#ifdef CONFIG_SPL_BUILD
+       /* Always force clock manager into boot mode before any configuration */
+       clk_write_ctrl(plat,
+                      CM_REG_READL(plat, CLKMGR_CTRL) | CLKMGR_CTRL_BOOTMODE);
+#else
+       /* Skip clock configuration in SSBL if it's not in boot mode */
+       if (!(CM_REG_READL(plat, CLKMGR_CTRL) & CLKMGR_CTRL_BOOTMODE))
+               return;
+#endif
+
        /* Put both PLLs in bypass */
        clk_write_bypass_mainpll(plat, CLKMGR_BYPASS_MAINPLL_ALL);
        clk_write_bypass_perpll(plat, CLKMGR_BYPASS_PERPLL_ALL);