gpio: zynq: Check return value of irq_get_irq_data
authorSrinivas Neeli <srinivas.neeli@xilinx.com>
Fri, 9 Apr 2021 14:08:06 +0000 (19:38 +0530)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 14 Jun 2021 18:21:21 +0000 (20:21 +0200)
In two different instances the return value of "irq_get_irq_data"
API was neither captured nor checked.
Fixed it by capturing the return value and then checking for any error.

Addresses-Coverity: "returned_null"
Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-zynq.c

index c91302a..f0cb8cc 100644 (file)
@@ -736,6 +736,11 @@ static int __maybe_unused zynq_gpio_suspend(struct device *dev)
        struct zynq_gpio *gpio = dev_get_drvdata(dev);
        struct irq_data *data = irq_get_irq_data(gpio->irq);
 
+       if (!data) {
+               dev_err(dev, "irq_get_irq_data() failed\n");
+               return -EINVAL;
+       }
+
        if (!device_may_wakeup(dev))
                disable_irq(gpio->irq);
 
@@ -753,6 +758,11 @@ static int __maybe_unused zynq_gpio_resume(struct device *dev)
        struct irq_data *data = irq_get_irq_data(gpio->irq);
        int ret;
 
+       if (!data) {
+               dev_err(dev, "irq_get_irq_data() failed\n");
+               return -EINVAL;
+       }
+
        if (!device_may_wakeup(dev))
                enable_irq(gpio->irq);