projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2f8cf5f
)
spi: mxic: Fix an error handling path in mxic_spi_probe()
author
Christophe JAILLET
<christophe.jaillet@wanadoo.fr>
Sun, 3 Apr 2022 10:11:13 +0000
(12:11 +0200)
committer
Mark Brown
<broonie@kernel.org>
Mon, 4 Apr 2022 07:45:14 +0000
(08:45 +0100)
If spi_register_master() fails, we must undo a previous
mxic_spi_mem_ecc_probe() call, as already done in the remove function.
Fixes:
00360ebae483
("spi: mxic: Add support for pipelined ECC operations")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link:
https://lore.kernel.org/r/09c81f751241f6ec0bac7a48d4ec814a742e0d17.1648980664.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mxic.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-mxic.c
b/drivers/spi/spi-mxic.c
index
55c0920
..
65be8e0
100644
(file)
--- a/
drivers/spi/spi-mxic.c
+++ b/
drivers/spi/spi-mxic.c
@@
-813,6
+813,7
@@
static int mxic_spi_probe(struct platform_device *pdev)
if (ret) {
dev_err(&pdev->dev, "spi_register_master failed\n");
pm_runtime_disable(&pdev->dev);
+ mxic_spi_mem_ecc_remove(mxic);
}
return ret;