drm/amdgpu/powerplay: hwmgr - modify the return value

Return value should be -EINVAL rather than EINVAL

Fixes: f83a9991648bb("drm/amd/powerplay: add Vega10 powerplay support (v5)")
Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)")
Cc: Eric Huang <JinHuiEric.Huang@amd.com>
Cc: Evan Quan <evan.quan@amd.com>
Reviewed-by: Evan Quan <evan.quan@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Xiaoliang Pang <dawning.pang@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
index c378a00..7eada30 100644 (file)
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
@@ -4659,7 +4659,7 @@ static int vega10_display_configuration_changed_task(struct pp_hwmgr *hwmgr)
        if ((data->water_marks_bitmap & WaterMarksExist) &&
                        !(data->water_marks_bitmap & WaterMarksLoaded)) {
                result = smum_smc_table_manager(hwmgr, (uint8_t *)wm_table, WMTABLE, false);
-               PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return EINVAL);
+               PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return -EINVAL);
                data->water_marks_bitmap |= WaterMarksLoaded;
        }
 

diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c
index f0680dd..dc206fa 100644 (file)
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c
@@ -2444,7 +2444,7 @@ static int vega12_display_configuration_changed_task(struct pp_hwmgr *hwmgr)
                        !(data->water_marks_bitmap & WaterMarksLoaded)) {
                result = smum_smc_table_manager(hwmgr,
                                                (uint8_t *)wm_table, TABLE_WATERMARKS, false);
-               PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return EINVAL);
+               PP_ASSERT_WITH_CODE(result, "Failed to update WMTABLE!", return -EINVAL);
                data->water_marks_bitmap |= WaterMarksLoaded;
        }