projects
/
platform
/
upstream
/
llvm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8a5bc6e
)
Improve overflow detection in StringRef::getAsUnsignedInteger().
author
Nick Kledzik
<kledzik@apple.com>
Tue, 2 Oct 2012 20:01:48 +0000
(20:01 +0000)
committer
Nick Kledzik
<kledzik@apple.com>
Tue, 2 Oct 2012 20:01:48 +0000
(20:01 +0000)
llvm-svn: 165038
llvm/lib/Support/StringRef.cpp
patch
|
blob
|
history
diff --git
a/llvm/lib/Support/StringRef.cpp
b/llvm/lib/Support/StringRef.cpp
index
8aab4b2
..
f8e9208
100644
(file)
--- a/
llvm/lib/Support/StringRef.cpp
+++ b/
llvm/lib/Support/StringRef.cpp
@@
-350,8
+350,8
@@
bool llvm::getAsUnsignedInteger(StringRef Str, unsigned Radix,
unsigned long long PrevResult = Result;
Result = Result*Radix+CharVal;
- // Check for overflow.
- if (Result < PrevResult)
+ // Check for overflow
by shifting back and seeing if bits were lost
.
+ if (Result
/Radix
< PrevResult)
return true;
Str = Str.substr(1);