crypto: tegra-aes - fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Mon, 17 Sep 2012 17:28:28 +0000 (19:28 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 27 Sep 2012 05:32:15 +0000 (13:32 +0800)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/tegra-aes.c

index 631149e..37185e6 100644 (file)
@@ -969,6 +969,7 @@ static int tegra_aes_probe(struct platform_device *pdev)
        aes_wq = alloc_workqueue("tegra_aes_wq", WQ_HIGHPRI | WQ_UNBOUND, 1);
        if (!aes_wq) {
                dev_err(dev, "alloc_workqueue failed\n");
+               err = -ENOMEM;
                goto out;
        }