Revert Trust the arange accelerator tables in dSYMs
authorAdrian Prantl <aprantl@apple.com>
Tue, 8 Oct 2019 21:34:22 +0000 (21:34 +0000)
committerAdrian Prantl <aprantl@apple.com>
Tue, 8 Oct 2019 21:34:22 +0000 (21:34 +0000)
This reverts r374117 (git commit 6399db2f6fd64fa250093368be40eb5ae3af513b)
while inspecting bot breakage.

llvm-svn: 374121

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp

index 57e6d12..1e04bac 100644 (file)
@@ -54,19 +54,13 @@ llvm::Expected<DWARFDebugAranges &> DWARFDebugInfo::GetCompileUnitAranges() {
 
   // Manually build arange data for everything that wasn't in the
   // .debug_aranges table.
-  //
-  // This step is skipped for dSYMs and other debug-info-only
-  // objects, which are always trusted to have a complete table.
-  auto *obj = m_dwarf.GetObjectFile();
-  if (!obj || obj->GetType() != ObjectFile::eTypeDebugInfo) {
-    const size_t num_units = GetNumUnits();
-    for (size_t idx = 0; idx < num_units; ++idx) {
-      DWARFUnit *cu = GetUnitAtIndex(idx);
-
-      dw_offset_t offset = cu->GetOffset();
-      if (cus_with_data.find(offset) == cus_with_data.end())
-        cu->BuildAddressRangeTable(m_cu_aranges_up.get());
-    }
+  const size_t num_units = GetNumUnits();
+  for (size_t idx = 0; idx < num_units; ++idx) {
+    DWARFUnit *cu = GetUnitAtIndex(idx);
+
+    dw_offset_t offset = cu->GetOffset();
+    if (cus_with_data.find(offset) == cus_with_data.end())
+      cu->BuildAddressRangeTable(m_cu_aranges_up.get());
   }
 
   const bool minimize = true;