fs/ntfs3: Check for NULL if ATTR_EA_INFO is incorrect
authorKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Wed, 29 Sep 2021 16:29:52 +0000 (19:29 +0300)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Thu, 30 Sep 2021 16:58:25 +0000 (19:58 +0300)
This can be reason for reported panic
https://lore.kernel.org/ntfs3/f9de5807-2311-7374-afb0-bc5dffb522c0@gmail.com/
Fixes: 4342306f0f0d ("fs/ntfs3: Add file operations and implementation")

Reported-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/frecord.c

index 9a53f80..007602b 100644 (file)
@@ -3080,7 +3080,9 @@ static bool ni_update_parent(struct ntfs_inode *ni, struct NTFS_DUP_INFO *dup,
                        const struct EA_INFO *info;
 
                        info = resident_data_ex(attr, sizeof(struct EA_INFO));
-                       dup->ea_size = info->size_pack;
+                       /* If ATTR_EA_INFO exists 'info' can't be NULL. */
+                       if (info)
+                               dup->ea_size = info->size_pack;
                }
        }