smb3 - clean up debug output displaying network interfaces
authorSteve French <stfrench@microsoft.com>
Sat, 20 Oct 2018 02:21:37 +0000 (21:21 -0500)
committerSteve French <stfrench@microsoft.com>
Wed, 24 Oct 2018 02:16:06 +0000 (21:16 -0500)
Make the output of /proc/fs/cifs/DebugData a little easier to
read by cleaning up the listing of network interfaces removing
a wasted line break.

Here is a comparison of the network interface information
that from be viewed at the end of output from

     "cat /proc/fs/cifs/DebugData"

Before:

Server interfaces: 8
0)
Speed: 10000000000 bps
Capabilities: rss
IPv6: fe80:0000:0000:0000:2cf5:407e:84b0:21dd
1)
Speed: 1000000000 bps
Capabilities:
IPv6: fe80:0000:0000:0000:61cd:6147:3d0c:f484

vs. after:

Server interfaces: 11
0) Speed: 10000000000 bps
Capabilities: rss
IPv6: fe80:0000:0000:0000:2cf5:407e:84b0:21dd
1) Speed: 2000000000 bps
Capabilities:
IPv6: fe80:0000:0000:0000:3d76:2d05:dcf8:ed10

Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/cifs_debug.c

index 3ae62ec..3e81242 100644 (file)
@@ -132,7 +132,7 @@ cifs_dump_iface(struct seq_file *m, struct cifs_server_iface *iface)
        struct sockaddr_in *ipv4 = (struct sockaddr_in *)&iface->sockaddr;
        struct sockaddr_in6 *ipv6 = (struct sockaddr_in6 *)&iface->sockaddr;
 
-       seq_printf(m, "\t\tSpeed: %zu bps\n", iface->speed);
+       seq_printf(m, "\tSpeed: %zu bps\n", iface->speed);
        seq_puts(m, "\t\tCapabilities: ");
        if (iface->rdma_capable)
                seq_puts(m, "rdma ");
@@ -354,7 +354,7 @@ skip_rdma:
                                seq_printf(m, "\n\tServer interfaces: %zu\n",
                                           ses->iface_count);
                        for (j = 0; j < ses->iface_count; j++) {
-                               seq_printf(m, "\t%d)\n", j);
+                               seq_printf(m, "\t%d)", j);
                                cifs_dump_iface(m, &ses->iface_list[j]);
                        }
                        spin_unlock(&ses->iface_lock);