projects
/
platform
/
upstream
/
llvm.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
25c94eb
)
Add a fixme to resetTargetOptions to explain why it needs to go
author
Eric Christopher
<echristo@gmail.com>
Tue, 28 Apr 2015 18:09:05 +0000
(18:09 +0000)
committer
Eric Christopher
<echristo@gmail.com>
Tue, 28 Apr 2015 18:09:05 +0000
(18:09 +0000)
away.
llvm-svn: 236009
llvm/lib/Target/TargetMachine.cpp
patch
|
blob
|
history
diff --git
a/llvm/lib/Target/TargetMachine.cpp
b/llvm/lib/Target/TargetMachine.cpp
index
5807cf7
..
69900b0
100644
(file)
--- a/
llvm/lib/Target/TargetMachine.cpp
+++ b/
llvm/lib/Target/TargetMachine.cpp
@@
-54,6
+54,11
@@
TargetMachine::~TargetMachine() {
}
/// \brief Reset the target options based on the function's attributes.
+// FIXME: This function needs to go away for a number of reasons:
+// a) global state on the TargetMachine is terrible in general,
+// b) there's no default state here to keep,
+// c) these target options should be passed only on the function
+// and not on the TargetMachine (via TargetOptions) at all.
void TargetMachine::resetTargetOptions(const Function &F) const {
#define RESET_OPTION(X, Y) \
do { \