De-inline QItemEditorCreatorBase destructor.

Virtual destructors on public exported API should not be inline.

Change-Id: I05bff0412ac97d2d8bd3cf8944f4fff2cb619f54
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>

diff --git a/src/widgets/itemviews/qitemeditorfactory.cpp b/src/widgets/itemviews/qitemeditorfactory.cpp
index f970a77..7ab34a6 100644 (file)
--- a/src/widgets/itemviews/qitemeditorfactory.cpp
+++ b/src/widgets/itemviews/qitemeditorfactory.cpp
@@ -358,6 +358,10 @@ void QItemEditorFactory::setDefaultFactory(QItemEditorFactory *factory)
 
     Destroys the editor creator object.
 */
+QItemEditorCreatorBase::~QItemEditorCreatorBase()
+{
+
+}
 
 /*!
     \fn QWidget *QItemEditorCreatorBase::createWidget(QWidget *parent) const

diff --git a/src/widgets/itemviews/qitemeditorfactory.h b/src/widgets/itemviews/qitemeditorfactory.h
index 8bc1cc7..a57d766 100644 (file)
--- a/src/widgets/itemviews/qitemeditorfactory.h
+++ b/src/widgets/itemviews/qitemeditorfactory.h
@@ -59,7 +59,7 @@ class QWidget;
 class Q_WIDGETS_EXPORT QItemEditorCreatorBase
 {
 public:
-    virtual ~QItemEditorCreatorBase() {}
+    virtual ~QItemEditorCreatorBase();
 
     virtual QWidget *createWidget(QWidget *parent) const = 0;
     virtual QByteArray valuePropertyName() const = 0;