[Title] added some comments & deleted unnecessary code
authorgiwoong.kim <giwoong.kim@samsung.com>
Fri, 14 Sep 2012 06:50:59 +0000 (15:50 +0900)
committergiwoong.kim <giwoong.kim@samsung.com>
Fri, 14 Sep 2012 06:50:59 +0000 (15:50 +0900)
[Type] enhancement
[Module] Emulator
[Priority] minor
[Jira#]
[Redmine#]
[Problem]
[Cause]
[Solution]
[TestCase]

tizen/src/hw/maru_device_ids.h
tizen/src/skin/client/src/org/tizen/emulator/skin/dialog/DetailInfoDialog.java

index 46b81d8..9d61c6e 100644 (file)
 #define PCI_DEVICE_ID_VIRTUAL_BRIGHTNESS 0x1014
 #define PCI_DEVICE_ID_VIRTUAL_CAMERA     0x1018
 #define PCI_DEVICE_ID_VIRTUAL_CODEC      0x101C
+// Device ID 0x1000 through 0x103F inclusive is a virtio device
 #define PCI_DEVICE_ID_VIRTIO_TOUCHSCREEN 0x101D
 
-/* virtio */
-#define VIRTIO_ID_TOUCHSCREEN 10
+/* Virtio */
+/*
++----------------------+--------------------+---------------+
+| Subsystem Device ID  |   Virtio Device    | Specification |
++----------------------+--------------------+---------------+
++----------------------+--------------------+---------------+
+|          1           |   network card     |  Appendix C   |
++----------------------+--------------------+---------------+
+|          2           |   block device     |  Appendix D   |
++----------------------+--------------------+---------------+
+|          3           |      console       |  Appendix E   |
++----------------------+--------------------+---------------+
+|          4           |  entropy source    |  Appendix F   |
++----------------------+--------------------+---------------+
+|          5           | memory ballooning  |  Appendix G   |
++----------------------+--------------------+---------------+
+|          6           |     ioMemory       |       -       |
++----------------------+--------------------+---------------+
+|          7           |       rpmsg        |  Appendix H   |
++----------------------+--------------------+---------------+
+|          8           |     SCSI host      |  Appendix I   |
++----------------------+--------------------+---------------+
+|          9           |   9P transport     |       -       |
++----------------------+--------------------+---------------+
+|         10           |   mac80211 wlan    |       -       |
++----------------------+--------------------+---------------+
+*/
+#define VIRTIO_ID_TOUCHSCREEN 11
 
 
 #endif /* MARU_DEVICE_IDS_H_ */
index 14820cd..628464c 100644 (file)
@@ -166,29 +166,6 @@ public class DetailInfoDialog extends SkinDialog {
                                        return;
                                }
 
-                               ProcessBuilder procBrowser = new ProcessBuilder();
-
-                               if (SwtUtil.isLinuxPlatform()) {
-                                       procBrowser.command("nautilus", "--browser", openPath);
-                               } else if (SwtUtil.isWindowsPlatform()) {
-                                       procBrowser.command("explorer", "\"" + openPath + "\"");
-                               } else if (SwtUtil.isMacPlatform()) {
-                                       //TODO:
-                                       logger.warning( "not supported yet" );
-                               }
-
-                               if (procBrowser.command().isEmpty() == false) {
-                                       try {
-                                               procBrowser.start();
-                                       } catch (Exception e) {
-                                               logger.log( Level.SEVERE, e.getMessage(), e);
-                                       }
-                               }
-
-                               if (openPath.compareTo(VALUE_NONE) == 0 || openPath.compareTo("") == 0) {
-                                       return;
-                               }
-
                                Program.launch(openPath);
 
                                /*ProcessBuilder procBrowser = new ProcessBuilder();