radeonsi/vcn: check fence before destroying decoder
authorBoyuan Zhang <boyuan.zhang@amd.com>
Fri, 20 Jan 2023 04:23:56 +0000 (23:23 -0500)
committerMarge Bot <emma+marge@anholt.net>
Mon, 23 Jan 2023 17:46:54 +0000 (17:46 +0000)
Add a fence_wait before destroying decoder to make sure destory message has
been processed by firmware.

Signed-off-by: Boyuan Zhang <boyuan.zhang@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Reviewed-by: Sajeesh Sidharthan <sajeesh.sidharthan@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20805>

src/gallium/drivers/radeonsi/radeon_vcn_dec.c
src/gallium/drivers/radeonsi/radeon_vcn_dec.h

index 7e52a1e..5568bc3 100644 (file)
@@ -2737,7 +2737,8 @@ static void radeon_dec_destroy(struct pipe_video_codec *decoder)
       map_msg_fb_it_probs_buf(dec);
       rvcn_dec_message_destroy(dec);
       send_msg_buf(dec);
-      flush(dec, 0, NULL);
+      flush(dec, 0, &dec->destroy_fence);
+      dec->ws->fence_wait(dec->ws, dec->destroy_fence, PIPE_DEFAULT_DECODER_FEEDBACK_TIMEOUT_NS);
    }
 
    dec->ws->cs_destroy(&dec->cs);
index b9d2f0d..3a586a2 100644 (file)
@@ -115,6 +115,7 @@ struct radeon_decoder {
    unsigned cb_idx;
    unsigned njctx;
    struct pipe_fence_handle *prev_fence;
+   struct pipe_fence_handle *destroy_fence;
 };
 
 void send_cmd_dec(struct radeon_decoder *dec, struct pipe_video_buffer *target,