elementary: Reduce EO calls by using geometry_set
authorChris Michael <cp.michael@samsung.com>
Wed, 21 Nov 2018 15:42:35 +0000 (10:42 -0500)
committerHermet Park <hermetpark@gmail.com>
Wed, 5 Dec 2018 05:30:05 +0000 (14:30 +0900)
This patch reduces EO calls by using evas_object_geometry_set rather
than calling move & resize.

src/lib/elementary/efl_selection_manager.c

index 7f1a7c12dca18830794b5f8f77cd7567cb8437de..cbca88bb1241e39fa2a7caae6a3830e2c83d7736 100644 (file)
@@ -2301,16 +2301,8 @@ _wl_efl_sel_manager_drag_start(Eo *obj EINA_UNUSED, Efl_Selection_Manager_Data *
    seat_sel->drag_win_start.x = seat_sel->drag_win_end.x = x;
    seat_sel->drag_win_start.y = seat_sel->drag_win_end.y = y;
 
-   //TIZEN_ONLY(20180724): Supporting Drag and Drop
-   //FIXME(20180724): If drag_win is resized first, drag_win will not be visible.
-   //                 It should be fixed later.
-   //evas_object_move(seat_sel->drag_win, x, y);
-   //evas_object_resize(seat_sel->drag_win, w, h);
-   //evas_object_show(seat_sel->drag_win);
+   evas_object_geometry_set(seat_sel->drag_win, x, y, w, h);
    evas_object_show(seat_sel->drag_win);
-   evas_object_move(seat_sel->drag_win, x, y);
-   evas_object_resize(seat_sel->drag_win, w, h);
-   //
 
    evas_pointer_canvas_xy_get(evas_object_evas_get(drag_obj), &x3, &y3);
    seat_sel->drag_pos.x = x3 - x2;
@@ -4546,8 +4538,7 @@ _drag_anim_play(void *data, double pos)
              h = ai->start.h - ((dc->final_icon.h - ai->start.h) * pos);
              x = ai->start.x - (pos * (ai->start.x + (w / 2) - xm));
              y = ai->start.y - (pos * (ai->start.y + (h / 2) - ym));
-             evas_object_move(ai->obj, x, y);
-             evas_object_resize(ai->obj, w, h);
+             evas_object_geometry_set(ai->obj, x, y, w, h);
           }
 
         return ECORE_CALLBACK_RENEW;