r8169: silence sparse warning in rtl8169_start_xmit
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 6 Jun 2019 05:49:17 +0000 (07:49 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Jun 2019 17:23:31 +0000 (10:23 -0700)
The opts[] array is of type u32. Therefore remove the wrong
cpu_to_le32(). The opts[] array members are converted to little endian
later when being assigned to the respective descriptor fields.

This is not a new issue, it just popped up due to r8169.c having
been renamed and more thoroughly checked. Due to the renaming
this patch applies to net-next only.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index d34cc85..8b7d45f 100644 (file)
@@ -5621,7 +5621,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
        if (unlikely(le32_to_cpu(txd->opts1) & DescOwn))
                goto err_stop_0;
 
-       opts[1] = cpu_to_le32(rtl8169_tx_vlan_tag(skb));
+       opts[1] = rtl8169_tx_vlan_tag(skb);
        opts[0] = DescOwn;
 
        if (rtl_chip_supports_csum_v2(tp)) {