hwmon: (ltc2945) Handle error case in ltc2945_value_store
authorJonathan Cormier <jcormier@criticallink.com>
Thu, 26 Jan 2023 22:32:25 +0000 (17:32 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:33:20 +0000 (09:33 +0100)
[ Upstream commit 178b01eccfb0b8149682f61388400bd3d903dddc ]

ltc2945_val_to_reg errors were not being handled
which would have resulted in register being set to
0 (clamped) instead of being left alone.

Fixes: 6700ce035f83 ("hwmon: Driver for Linear Technologies LTC2945")

Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/ltc2945.c

index 9adebb5..c06ab73 100644 (file)
@@ -248,6 +248,8 @@ static ssize_t ltc2945_value_store(struct device *dev,
 
        /* convert to register value, then clamp and write result */
        regval = ltc2945_val_to_reg(dev, reg, val);
+       if (regval < 0)
+               return regval;
        if (is_power_reg(reg)) {
                regval = clamp_val(regval, 0, 0xffffff);
                regbuf[0] = regval >> 16;