gst/base/gstbasesink.c (gst_basesink_chain): Remove bogus assert; it's always possibl...

Original commit message from CVS:
2005-06-17  Andy Wingo  <wingo@pobox.com>

* gst/base/gstbasesink.c (gst_basesink_chain): Remove bogus
assert; it's always possible that the pad gets deactivated in
between the checks in gstpad.c and the implementation. Rely on
finish_preroll() to return a FLUSHING or similar instead of on the
assert.

diff --git a/gst/base/gstbasesink.c b/gst/base/gstbasesink.c
index 736089659676eac2af8efc829b440c4d193e3b8f..c54ee854b53405cde125c66beaf7264a27f1e1b1 100644 (file)
--- a/gst/base/gstbasesink.c
+++ b/gst/base/gstbasesink.c
@@ -739,9 +739,6 @@ gst_basesink_chain (GstPad * pad, GstBuffer * buf)
 {
   GstFlowReturn result;
 
-  g_assert (GST_BASESINK (GST_OBJECT_PARENT (pad))->pad_mode ==
-      GST_ACTIVATE_PUSH);
-
   result = gst_basesink_chain_unlocked (pad, buf);
 
   return result;

diff --git a/libs/gst/base/gstbasesink.c b/libs/gst/base/gstbasesink.c
index 736089659676eac2af8efc829b440c4d193e3b8f..c54ee854b53405cde125c66beaf7264a27f1e1b1 100644 (file)
--- a/libs/gst/base/gstbasesink.c
+++ b/libs/gst/base/gstbasesink.c
@@ -739,9 +739,6 @@ gst_basesink_chain (GstPad * pad, GstBuffer * buf)
 {
   GstFlowReturn result;
 
-  g_assert (GST_BASESINK (GST_OBJECT_PARENT (pad))->pad_mode ==
-      GST_ACTIVATE_PUSH);
-
   result = gst_basesink_chain_unlocked (pad, buf);
 
   return result;