net: phy: motorcomm: uninitialized variables in yt8531_link_change_notify()
authorDan Carpenter <error27@gmail.com>
Wed, 15 Feb 2023 04:21:47 +0000 (07:21 +0300)
committerJaehoon Chung <jh80.chung@samsung.com>
Mon, 24 Jul 2023 23:24:51 +0000 (08:24 +0900)
These booleans are never set to false, but are just used without being
initialized.

Fixes: 4ac94f728a58 ("net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Frank Sae <Frank.Sae@motor-comm.com>
Link: https://lore.kernel.org/r/Y+xd2yJet2ImHLoQ@kili
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Change-Id: I1b34e53290b0e99aa7d2e5c7269625cdc6a779cb

drivers/net/phy/motorcomm.c

index ee7c37d..2fa5a90 100644 (file)
@@ -1533,10 +1533,10 @@ static int yt8531_config_init(struct phy_device *phydev)
 static void yt8531_link_change_notify(struct phy_device *phydev)
 {
        struct device_node *node = phydev->mdio.dev.of_node;
+       bool tx_clk_1000_inverted = false;
+       bool tx_clk_100_inverted = false;
+       bool tx_clk_10_inverted = false;
        bool tx_clk_adj_enabled = false;
-       bool tx_clk_1000_inverted;
-       bool tx_clk_100_inverted;
-       bool tx_clk_10_inverted;
        u16 val = 0;
        int ret;