drm/msm/adreno: bit of init refactoring

Push a few bits down into adreno_gpu so they won't have to be duplicated
as support for additional adreno generations is added.

Signed-off-by: Rob Clark <robdclark@gmail.com>

diff --git a/drivers/gpu/drm/msm/adreno/a3xx_gpu.c b/drivers/gpu/drm/msm/adreno/a3xx_gpu.c
index 42bdcf7..b7116cb 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a3xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a3xx_gpu.c
@@ -35,10 +35,8 @@
         A3XX_INT0_CP_AHB_ERROR_HALT |     \
         A3XX_INT0_UCHE_OOB_ACCESS)
 
+extern bool hang_debug;
 
-static bool hang_debug = false;
-MODULE_PARM_DESC(hang_debug, "Dump registers when hang is detected (can be slow!)");
-module_param_named(hang_debug, hang_debug, bool, 0600);
 static void a3xx_dump(struct msm_gpu *gpu);
 
 static void a3xx_me_init(struct msm_gpu *gpu)
@@ -474,7 +472,6 @@ struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)
        struct msm_gpu *gpu;
        struct msm_drm_private *priv = dev->dev_private;
        struct platform_device *pdev = priv->gpu_pdev;
-       struct adreno_platform_config *config;
        int ret;
 
        if (!pdev) {
@@ -483,8 +480,6 @@ struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)
                goto fail;
        }
 
-       config = pdev->dev.platform_data;
-
        a3xx_gpu = kzalloc(sizeof(*a3xx_gpu), GFP_KERNEL);
        if (!a3xx_gpu) {
                ret = -ENOMEM;
@@ -496,20 +491,10 @@ struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)
 
        a3xx_gpu->pdev = pdev;
 
-       gpu->fast_rate = config->fast_rate;
-       gpu->slow_rate = config->slow_rate;
-       gpu->bus_freq  = config->bus_freq;
-#ifdef CONFIG_MSM_BUS_SCALING
-       gpu->bus_scale_table = config->bus_scale_table;
-#endif
-
-       DBG("fast_rate=%u, slow_rate=%u, bus_freq=%u",
-                       gpu->fast_rate, gpu->slow_rate, gpu->bus_freq);
-
        gpu->perfcntrs = perfcntrs;
        gpu->num_perfcntrs = ARRAY_SIZE(perfcntrs);
 
-       ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs, config->rev);
+       ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs);
        if (ret)
                goto fail;
 

diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index b03290e..7ab85af 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -23,6 +23,10 @@
 
 #define ANY_ID 0xff
 
+bool hang_debug = false;
+MODULE_PARM_DESC(hang_debug, "Dump registers when hang is detected (can be slow!)");
+module_param_named(hang_debug, hang_debug, bool, 0600);
+
 struct msm_gpu *a3xx_gpu_init(struct drm_device *dev);
 
 static const struct adreno_info gpulist[] = {

diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index c64340f..d25f85c 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -265,39 +265,50 @@ static const char *iommu_ports[] = {
 };
 
 int adreno_gpu_init(struct drm_device *drm, struct platform_device *pdev,
-               struct adreno_gpu *gpu, const struct adreno_gpu_funcs *funcs,
-               struct adreno_rev rev)
+               struct adreno_gpu *adreno_gpu, const struct adreno_gpu_funcs *funcs)
 {
+       struct adreno_platform_config *config = pdev->dev.platform_data;
+       struct msm_gpu *gpu = &adreno_gpu->base;
        struct msm_mmu *mmu;
        int ret;
 
-       gpu->funcs = funcs;
-       gpu->info = adreno_info(rev);
-       gpu->gmem = gpu->info->gmem;
-       gpu->revn = gpu->info->revn;
-       gpu->rev = rev;
+       adreno_gpu->funcs = funcs;
+       adreno_gpu->info = adreno_info(config->rev);
+       adreno_gpu->gmem = adreno_gpu->info->gmem;
+       adreno_gpu->revn = adreno_gpu->info->revn;
+       adreno_gpu->rev = config->rev;
+
+       gpu->fast_rate = config->fast_rate;
+       gpu->slow_rate = config->slow_rate;
+       gpu->bus_freq  = config->bus_freq;
+#ifdef CONFIG_MSM_BUS_SCALING
+       gpu->bus_scale_table = config->bus_scale_table;
+#endif
+
+       DBG("fast_rate=%u, slow_rate=%u, bus_freq=%u",
+                       gpu->fast_rate, gpu->slow_rate, gpu->bus_freq);
 
-       ret = request_firmware(&gpu->pm4, gpu->info->pm4fw, drm->dev);
+       ret = request_firmware(&adreno_gpu->pm4, adreno_gpu->info->pm4fw, drm->dev);
        if (ret) {
                dev_err(drm->dev, "failed to load %s PM4 firmware: %d\n",
-                               gpu->info->pm4fw, ret);
+                               adreno_gpu->info->pm4fw, ret);
                return ret;
        }
 
-       ret = request_firmware(&gpu->pfp, gpu->info->pfpfw, drm->dev);
+       ret = request_firmware(&adreno_gpu->pfp, adreno_gpu->info->pfpfw, drm->dev);
        if (ret) {
                dev_err(drm->dev, "failed to load %s PFP firmware: %d\n",
-                               gpu->info->pfpfw, ret);
+                               adreno_gpu->info->pfpfw, ret);
                return ret;
        }
 
-       ret = msm_gpu_init(drm, pdev, &gpu->base, &funcs->base,
-                       gpu->info->name, "kgsl_3d0_reg_memory", "kgsl_3d0_irq",
+       ret = msm_gpu_init(drm, pdev, &adreno_gpu->base, &funcs->base,
+                       adreno_gpu->info->name, "kgsl_3d0_reg_memory", "kgsl_3d0_irq",
                        RB_SIZE);
        if (ret)
                return ret;
 
-       mmu = gpu->base.mmu;
+       mmu = gpu->mmu;
        if (mmu) {
                ret = mmu->funcs->attach(mmu, iommu_ports,
                                ARRAY_SIZE(iommu_ports));
@@ -306,24 +317,24 @@ int adreno_gpu_init(struct drm_device *drm, struct platform_device *pdev,
        }
 
        mutex_lock(&drm->struct_mutex);
-       gpu->memptrs_bo = msm_gem_new(drm, sizeof(*gpu->memptrs),
+       adreno_gpu->memptrs_bo = msm_gem_new(drm, sizeof(*adreno_gpu->memptrs),
                        MSM_BO_UNCACHED);
        mutex_unlock(&drm->struct_mutex);
-       if (IS_ERR(gpu->memptrs_bo)) {
-               ret = PTR_ERR(gpu->memptrs_bo);
-               gpu->memptrs_bo = NULL;
+       if (IS_ERR(adreno_gpu->memptrs_bo)) {
+               ret = PTR_ERR(adreno_gpu->memptrs_bo);
+               adreno_gpu->memptrs_bo = NULL;
                dev_err(drm->dev, "could not allocate memptrs: %d\n", ret);
                return ret;
        }
 
-       gpu->memptrs = msm_gem_vaddr(gpu->memptrs_bo);
-       if (!gpu->memptrs) {
+       adreno_gpu->memptrs = msm_gem_vaddr(adreno_gpu->memptrs_bo);
+       if (!adreno_gpu->memptrs) {
                dev_err(drm->dev, "could not vmap memptrs\n");
                return -ENOMEM;
        }
 
-       ret = msm_gem_get_iova(gpu->memptrs_bo, gpu->base.id,
-                       &gpu->memptrs_iova);
+       ret = msm_gem_get_iova(adreno_gpu->memptrs_bo, gpu->id,
+                       &adreno_gpu->memptrs_iova);
        if (ret) {
                dev_err(drm->dev, "could not map memptrs: %d\n", ret);
                return ret;

diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
index a1e1fbb..3664a0d 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
@@ -140,8 +140,7 @@ void adreno_dump(struct msm_gpu *gpu);
 void adreno_wait_ring(struct msm_gpu *gpu, uint32_t ndwords);
 
 int adreno_gpu_init(struct drm_device *drm, struct platform_device *pdev,
-               struct adreno_gpu *gpu, const struct adreno_gpu_funcs *funcs,
-               struct adreno_rev rev);
+               struct adreno_gpu *gpu, const struct adreno_gpu_funcs *funcs);
 void adreno_gpu_cleanup(struct adreno_gpu *gpu);