projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e3a1eae
)
mmc: sdhci-of-esdhc: Fix refcount leak in esdhc_signal_voltage_switch
author
Miaoqian Lin
<linmq006@gmail.com>
Mon, 23 May 2022 14:42:54 +0000
(18:42 +0400)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:23:50 +0000
(14:23 +0200)
[ Upstream commit
b5899a3e2f783a27b268e38d37f9b24c71bddf45
]
of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
of_node_put() checks null pointer.
Fixes:
ea35645a3c66
("mmc: sdhci-of-esdhc: add support for signal voltage switch")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link:
https://lore.kernel.org/r/20220523144255.10310-1-linmq006@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/sdhci-of-esdhc.c
patch
|
blob
|
history
diff --git
a/drivers/mmc/host/sdhci-of-esdhc.c
b/drivers/mmc/host/sdhci-of-esdhc.c
index
0f3658b
..
04a37fd
100644
(file)
--- a/
drivers/mmc/host/sdhci-of-esdhc.c
+++ b/
drivers/mmc/host/sdhci-of-esdhc.c
@@
-904,6
+904,7
@@
static int esdhc_signal_voltage_switch(struct mmc_host *mmc,
scfg_node = of_find_matching_node(NULL, scfg_device_ids);
if (scfg_node)
scfg_base = of_iomap(scfg_node, 0);
+ of_node_put(scfg_node);
if (scfg_base) {
sdhciovselcr = SDHCIOVSELCR_TGLEN |
SDHCIOVSELCR_VSELVAL;