James Bursa identified a libcurl HTTP bug and a good way to repeat it. If a

site responds with bad HTTP response that doesn't contain any header at all,
only a response body, and the write callback returns 0 to abort the
transfer, it didn't have any real effect but the write callback would be
called once more anyway.

diff --git a/lib/transfer.c b/lib/transfer.c
index a2cd39179341c39c02b9e998ae5bfe2eed4f6487..544ac8560a40fc555ba5baada391d9b682768559 100644 (file)
--- a/lib/transfer.c
+++ b/lib/transfer.c
@@ -1134,6 +1134,8 @@ CURLcode Curl_readwrite(struct connectdata *conn,
               result = Curl_client_write(data, CLIENTWRITE_BODY,
                                          data->state.headerbuff,
                                          k->hbuflen);
+              if(result)
+                return result;
             }
             if(k->badheader < HEADER_ALLBAD) {
               /* This switch handles various content encodings. If there's an