[flang] Remove some needless std::move() calls for readability.

Original-commit: flang-compiler/f18@88aadf45dccb6c7fe0443345842d6ecced2258bd
Reviewed-on: https://github.com/flang-compiler/f18/pull/48
Tree-same-pre-rewrite: false

diff --git a/flang/lib/parser/basic-parsers.h b/flang/lib/parser/basic-parsers.h
index f63c4248c1aff946adede86074e749c41e3b8fec..d543e55d998375726766e320ce0bb48d9a13bfa0 100644 (file)
--- a/flang/lib/parser/basic-parsers.h
+++ b/flang/lib/parser/basic-parsers.h
@@ -212,7 +212,7 @@ public:
   std::optional<resultType> Parse(ParseState *state) const {
     if (std::optional<resultType> ax{pa_.Parse(state)}) {
       if (pb_.Parse(state)) {
-        return std::move(ax);
+        return ax;
       }
     }
     return {};
@@ -1188,7 +1188,7 @@ constexpr struct NextCh {
   constexpr NextCh() {}
   std::optional<const char *> Parse(ParseState *state) const {
     if (std::optional<const char *> result{state->GetNextChar()}) {
-      return std::move(result);
+      return result;
     }
     state->Say("end of file"_err_en_US);
     return {};