i2c: cadence: Unregister the clk notifier in error path
authorSatish Nagireddy <satish.nagireddy@getcruise.com>
Tue, 28 Jun 2022 19:12:16 +0000 (12:12 -0700)
committerWolfram Sang <wsa@kernel.org>
Thu, 7 Jul 2022 21:06:34 +0000 (23:06 +0200)
This patch ensures that the clock notifier is unregistered
when driver probe is returning error.

Fixes: df8eb5691c48 ("i2c: Add driver for Cadence I2C controller")
Signed-off-by: Satish Nagireddy <satish.nagireddy@getcruise.com>
Tested-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-cadence.c

index b4c1ad19cdaec154f2a39186dca5f38932163a4f..3d6f8ee355bfce0413a73bcb1e89175c9fce3a10 100644 (file)
@@ -1338,6 +1338,7 @@ static int cdns_i2c_probe(struct platform_device *pdev)
        return 0;
 
 err_clk_dis:
+       clk_notifier_unregister(id->clk, &id->clk_rate_change_nb);
        clk_disable_unprepare(id->clk);
        pm_runtime_disable(&pdev->dev);
        pm_runtime_set_suspended(&pdev->dev);