tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of...

commit a9c09546e903f1068acfa38e1ee18bded7114b37 upstream.

If clk_get_rate() fails, the clk that has just been allocated needs to be
freed.

Cc: <stable@vger.kernel.org> # v3.3+
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Fixes: 5f5a7a5578c5 ("serial: samsung: switch to clkdev based clock lookup")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Message-ID: <e4baf6039368f52e5a5453982ddcb9a330fc689e.1686412569.git.christophe.jaillet@wanadoo.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 77d1363029f558b76d1e84dfb6b38a25ec44afdc..c8365a367513fc9111ea279c5d6dd6c4d553e2b7 100644 (file)
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -1467,8 +1467,12 @@ static unsigned int s3c24xx_serial_getclk(struct s3c24xx_uart_port *ourport,
                        continue;
 
                rate = clk_get_rate(clk);
-               if (!rate)
+               if (!rate) {
+                       dev_err(ourport->port.dev,
+                               "Failed to get clock rate for %s.\n", clkname);
+                       clk_put(clk);
                        continue;
+               }
 
                if (ourport->info->has_divslot) {
                        unsigned long div = rate / req_baud;