Add reviewers to roll_deps.py, remove linux_heapcheck bot
authorcommit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>
Tue, 21 Jan 2014 21:38:49 +0000 (21:38 +0000)
committercommit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>
Tue, 21 Jan 2014 21:38:49 +0000 (21:38 +0000)
The --reviewers and --cc are disabled for now, while we work on the workflow.

BUG=skia:
R=robertphillips@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/143903005

git-svn-id: http://skia.googlecode.com/svn/trunk@13137 2bbb7eff-a529-9590-31e7-b0007b416f81

tools/roll_deps.py

index 10822f4..b34baac 100755 (executable)
@@ -64,6 +64,15 @@ class DepsRollConfig(object):
         self.cl_bot_list = [bot for bot in options.bots.split(',') if bot]
         self.skia_git_checkout_path = options.skia_git_path
         self.default_branch_name = 'autogenerated_deps_roll_branch'
+        self.reviewers_list = ','.join([
+            # 'rmistry@google.com',
+            # 'reed@google.com',
+            # 'bsalomon@google.com',
+            # 'robertphillips@google.com',
+            ])
+        self.cc_list =  ','.join([
+            # 'skia-team@google.com',
+            ])
 
     @staticmethod
     def GetOptionParser():
@@ -85,7 +94,6 @@ class DepsRollConfig(object):
             'linux_chromeos',
             'linux_chromeos_asan',
             'linux_gpu',
-            'linux_heapcheck',
             'linux_layout',
             'linux_layout_rel',
             'mac',
@@ -604,8 +612,13 @@ class GitBranchCLUpload(object):
             vsp.check_call([git, 'add', filename])
         vsp.check_call([git, 'commit', '-q', '-m', self._message])
 
-        git_cl = [git, 'cl', 'upload', '-f', '--cc=skia-team@google.com',
+        git_cl = [git, 'cl', 'upload', '-f',
                   '--bypass-hooks', '--bypass-watchlists']
+        if self._config.cc_list:
+            git_cl.append('--cc=%s' % self._config.cc_list)
+        if self._config.reviewers_list:
+            git_cl.append('--reviewers=%s' % self._config.reviewers_list)
+
         git_try = [git, 'cl', 'try', '--revision', svn_info]
         git_try.extend([arg for bot in self._config.cl_bot_list
                         for arg in ('-b', bot)])