usb: cdnsp: Fixes issue with dequeuing not queued requests
authorPawel Laszczak <pawell@cadence.com>
Thu, 13 Jul 2023 08:14:29 +0000 (04:14 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 2 Oct 2023 11:19:13 +0000 (13:19 +0200)
Gadget ACM while unloading module try to dequeue not queued usb
request which causes the kernel to crash.
Patch adds extra condition to check whether usb request is processed
by CDNSP driver.

cc: stable@vger.kernel.org
Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Acked-by: Peter Chen <peter.chen@kernel.org>
Link: https://lore.kernel.org/r/20230713081429.326660-1-pawell@cadence.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/cdnsp-gadget.c

index fff9ec9..4b67749 100644 (file)
@@ -1125,6 +1125,9 @@ static int cdnsp_gadget_ep_dequeue(struct usb_ep *ep,
        unsigned long flags;
        int ret;
 
+       if (request->status != -EINPROGRESS)
+               return 0;
+
        if (!pep->endpoint.desc) {
                dev_err(pdev->dev,
                        "%s: can't dequeue to disabled endpoint\n",