From: Bluezery <ohpowel@gmail.com>

Subject: [E-devel] [ecore_file] Check a return value of
ecore_con_url_get()

_ecore_file_download_curl() does not check return value of  even if
ecore_con_url_get(), it can be failed.
I add a simple error checking.
Please review this patch.

git-svn-id: http://svn.enlightenment.org/svn/e/trunk/ecore@64795 7cbeb6ba-43b4-40fd-8cce-4c39aea84d33

diff --git a/src/lib/ecore_file/ecore_file_download.c b/src/lib/ecore_file/ecore_file_download.c
index 8811532..bed6f8d 100644 (file)
--- a/src/lib/ecore_file/ecore_file_download.c
+++ b/src/lib/ecore_file/ecore_file_download.c
@@ -369,7 +369,15 @@ _ecore_file_download_curl(const char *url, const char *dst,
    job->progress_cb = progress_cb;
    _job_list = eina_list_append(_job_list, job);
 
-   ecore_con_url_get(job->url_con);
+   if (!ecore_con_url_get(job->url_con))
+     {
+        ecore_con_url_free(job->url_con);
+        _job_list = eina_list_remove(_job_list, job);
+        fclose(job->file);
+        free(job->dst);
+        free(job);
+        return NULL;
+     }
 
    return job;
 }