Fix a memory leak issue with a minor CRC fix 62/152662/3 accepted/tizen/unified/20171011.065810 submit/tizen/20171010.081858
authorTaesoo Jun <steve.jun@samsung.com>
Wed, 27 Sep 2017 00:25:34 +0000 (09:25 +0900)
committersinikang <sinikang@samsung.com>
Thu, 28 Sep 2017 01:34:43 +0000 (10:34 +0900)
 - fix for CID 24672, CID 35101

Change-Id: I7c7343ae8dee54950e295410b7c4db0d225d504d

packaging/tel-plugin-manager.spec
src/manager_call.c

index 4b4f83072aba48a2ca6cddd0e98a144da0e17c38..463a04efc2a8e5392feba57398107967b2b926e4 100644 (file)
@@ -1,6 +1,6 @@
 %define major 0
 %define minor 1
-%define patchlevel 6
+%define patchlevel 7
 
 Name:           tel-plugin-manager
 Version:        %{major}.%{minor}.%{patchlevel}
index 6f02b9b70b978590e0730bf72717df9ca2e8b7f0..9957ed1bffb1adc66a80c5291c6afe27dd4838d5 100644 (file)
@@ -551,6 +551,7 @@ static void on_resp_manager_set_ecc_status(UserRequest *ur,
        list = tcore_call_object_find_by_status(co_call, TCORE_CALL_STATUS_SETUP_PENDING);
        if (list == NULL) {
                err("No TCORE_CALL_STATUS_SETUP_PENDING status call!!!");
+               g_free(modem_name);
                return;
        }
        call_obj = list->data;
@@ -1172,10 +1173,12 @@ enum tcore_manager_return manager_call_process_request(Server *server, UserReque
                tcore_network_get_service_type(co_network, &svc_type);
                session_list = tcore_call_object_get_all_session_ids(co_call);
 
-               if ((NETWORK_SERVICE_TYPE_LTE != svc_type) && session_list) {
-                       dbg("Not on LTE network - But still old VoLTE call is present - return ERROR !!");
+               if (session_list) {
                        g_slist_free(session_list);
-                       return TCORE_MANAGER_RETURN_FAILURE;
+                       if (NETWORK_SERVICE_TYPE_LTE != svc_type) {
+                               dbg("Not on LTE network - But still old VoLTE call is present - return ERROR !!");
+                               return TCORE_MANAGER_RETURN_FAILURE;
+                       }
                }
 
 
@@ -1545,7 +1548,7 @@ gboolean manager_call_initialize_private_info(ModemBoard *mb)
                manager_call_clear_private_info(mb);
 
        mb->call_info = g_try_malloc0(sizeof(struct manager_call_private_info));
-       if(mb->call_info == NULL) {
+       if (mb->call_info == NULL) {
                err("Memory alloc failed");
                return FALSE;
        }