lib: utils/irqchip: plic: Fix the off-by-one error in priority save/restore helpers
authorBin Meng <bmeng@tinylab.org>
Sun, 11 Dec 2022 06:54:20 +0000 (14:54 +0800)
committerAnup Patel <anup@brainfault.org>
Sat, 17 Dec 2022 03:12:21 +0000 (08:42 +0530)
Interrupt source 0 is reserved. Hence the irq should start from 1.

Fixes: 2b79b694a805 ("lib: irqchip/plic: Add priority save/restore helpers")
Signed-off-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Anup Patel <anup@brainfault.org>
lib/utils/irqchip/plic.c

index 73d7788..4df9020 100644 (file)
@@ -38,13 +38,13 @@ static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val)
 
 void plic_priority_save(const struct plic_data *plic, u8 *priority)
 {
-       for (u32 i = 0; i < plic->num_src; i++)
+       for (u32 i = 1; i <= plic->num_src; i++)
                priority[i] = plic_get_priority(plic, i);
 }
 
 void plic_priority_restore(const struct plic_data *plic, const u8 *priority)
 {
-       for (u32 i = 0; i < plic->num_src; i++)
+       for (u32 i = 1; i <= plic->num_src; i++)
                plic_set_priority(plic, i, priority[i]);
 }