tests/docker: fix make-archive-maybe
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 6 Jun 2016 14:46:52 +0000 (16:46 +0200)
committerFam Zheng <famz@redhat.com>
Wed, 8 Jun 2016 07:19:30 +0000 (15:19 +0800)
make-archive-maybe expects an archive path relative
to $1, but receives a path relative to the current directory.  Redirect
the output outside the subshell to bypass the "cd $1".

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 1465224417-141321-2-git-send-email-pbonzini@redhat.com
Signed-off-by: Fam Zheng <famz@redhat.com>
tests/docker/Makefile.include

index 134dc6f..f88c0a7 100644 (file)
@@ -21,10 +21,10 @@ IMAGES ?= %
 make-archive-maybe = $(if $(wildcard $1/*), \
        $(call quiet-command, \
                (cd $1; if git diff-index --quiet HEAD -- &>/dev/null; then \
-                       git archive -1 HEAD --format=tar.gz -o $2; \
+                       git archive -1 HEAD --format=tar.gz; \
                else \
-                       git archive -1 $$(git stash create) --format=tar.gz -o $2; \
-               fi), \
+                       git archive -1 $$(git stash create) --format=tar.gz; \
+               fi) > $2, \
                "  ARCHIVE $(notdir $2)"))
 
 CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.$$$$)