[Scrollable] Fix for clipper on go to top icon
authorGodly Thekkethottiyil Alias <godly.talias@samsung.com>
Tue, 28 Jan 2020 13:42:18 +0000 (19:12 +0530)
committerJaehyun Cho <jae_hyun.cho@samsung.com>
Thu, 13 Feb 2020 10:51:15 +0000 (19:51 +0900)
[Model] Noblesse
[BinType] N/A
[Customer] N/A
[Issue#] FWGOVERSEA-1520
[Request] UX
[Occurrence Version] N/A
[Problem] N/A
[Cause & Measure] Clipper added in edc creates flickering
                  Moving clipper addition to elementary
[Checking Method] N/A
[Team] (UIFW/EFL)
[Developer] Godly T.Alias
[Solution company] Samsung
[Change Type] New Feature

Change-Id: Ib2a81baa5248775f3742b6ca992685ca7acf28cb
Signed-off-by: Godly Thekkethottiyil Alias <godly.talias@samsung.com>
src/wearable/circle/efl_extension_circle_object_scroller.c

index d014117529ccd4a37de616ee9dec848f19d7b0e9..42c73f1b8e506d87c00198bcc7473b73b599c6da 100644 (file)
@@ -1567,18 +1567,6 @@ _eext_circle_object_scroller_init(Eext_Circle_Object *obj, Evas_Object *scroller
 }
 
 //TIZEN_ONLY(24Jan2020): Go To Top Feature
-static void
-_update_clipper_cb(void *data,
-                   Evas_Object *obj,
-                   void *event_info EINA_UNUSED)
-{
-   Evas_Object *edje_obj = elm_layout_edje_get(obj);
-   EEXT_CIRCLE_OBJECT_SCROLLER_SCROLL_IFACE_DATA_GET(obj, sid);
-
-   if (sid->gotop_clipper)
-     sid->gotop_clipper = edje_object_part_object_get(edje_obj, "elm.clip.gototop");
-}
-
 EAPI void
 eext_circle_object_scroller_gototop_enable_set(Evas_Object *obj, Eina_Bool enable, Evas_Smart_Cb func)
 {
@@ -1589,18 +1577,19 @@ eext_circle_object_scroller_gototop_enable_set(Evas_Object *obj, Eina_Bool enabl
 
    if (enable)
      {
-        Evas_Object *clipper = edje_object_part_object_get(edje_obj, "elm.clip.gototop");
-        sid->gotop_clipper = clipper;
         sid->is_gotop_shown = EINA_FALSE;
+        sid->is_gotop_enabled = EINA_TRUE;
         sid->gototop_cb = func;
-        evas_object_smart_callback_add(obj, "theme,changed", _update_clipper_cb, obj);
+        if (sid->gotop_clipper) evas_object_del(sid->gotop_clipper);
+        sid->gotop_clipper = NULL;
      }
    else
      {
+        if (sid->gotop_clipper) evas_object_del(sid->gotop_clipper);
         sid->gotop_clipper = NULL;
+        sid->is_gotop_enabled = EINA_FALSE;
         sid->gototop_cb = NULL;
         sid->is_gotop_shown = EINA_FALSE;
-        evas_object_smart_callback_del(obj, "theme,changed", _update_clipper_cb);
      }
 }
 //