serial: xuartps: remove unnecessary register write
authorHelmut Grohne <h.grohne@intenta.de>
Mon, 4 Jun 2018 10:22:19 +0000 (12:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Jun 2018 12:23:44 +0000 (21:23 +0900)
This writel writes the exact same value as the previous writel and is
thus unnecessary. It accidentally became unnecessary in e3538c37ee38
("tty: xuartps: Beautify read-modify writes"), but the new behaviour is
now expected.

Link: https://www.spinics.net/lists/linux-serial/msg23168.html
Signed-off-by: Helmut Grohne <h.grohne@intenta.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/xilinx_uartps.c

index 5f040ce..a48f19b 100644 (file)
@@ -1203,8 +1203,6 @@ static void cdns_uart_console_write(struct console *co, const char *s,
                        CDNS_UART_SR_TXEMPTY)
                cpu_relax();
 
-       writel(ctrl, port->membase + CDNS_UART_CR);
-
        /* restore interrupt state */
        writel(imr, port->membase + CDNS_UART_IER);