subparsers: Give proper category to subtitle "decoders"
authorEdward Hervey <edward@centricular.com>
Tue, 20 Feb 2024 15:00:07 +0000 (16:00 +0100)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Thu, 22 Feb 2024 14:39:54 +0000 (14:39 +0000)
Some subtitle "decoders" had a wrong category of "Parser", which `parsebin`
relies on to identify elements which do not *decode* streams but *parse* them.

This would cause such subtitle decoders to be plugged in within parsebin,
preventing the original stream to be properly used by (more efficient)
downstream decoders or subtitle renderers.

Fixes #1757

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/6153>

subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json
subprojects/gst-plugins-bad/ext/ttml/gstttmlparse.c
subprojects/gst-plugins-base/docs/plugins/gst_plugins_cache.json
subprojects/gst-plugins-base/gst/subparse/gstssaparse.c
subprojects/gst-plugins-base/gst/subparse/gstsubparse.c

index bcf4df8cf56140d8ce166d8ae1e2c3a3e7ebf136..022454cac531dd06696f7956b862e29c80d91a78 100644 (file)
                     "GInitiallyUnowned",
                     "GObject"
                 ],
-                "klass": "Codec/Parser/Subtitle",
+                "klass": "Codec/Decoder/Subtitle",
                 "long-name": "TTML subtitle parser",
                 "pad-templates": {
                     "sink": {
index eafa7193f87acdbf36effda5cb94a29d775fe85f..649a041699f47fa9cea2354644f9e8bdc848aa76 100644 (file)
@@ -129,7 +129,7 @@ gst_ttml_parse_class_init (GstTtmlParseClass * klass)
   gst_element_class_add_pad_template (element_class,
       gst_static_pad_template_get (&src_templ));
   gst_element_class_set_static_metadata (element_class,
-      "TTML subtitle parser", "Codec/Parser/Subtitle",
+      "TTML subtitle parser", "Codec/Decoder/Subtitle",
       "Parses TTML subtitle files",
       "GStreamer maintainers <gstreamer-devel@lists.sourceforge.net>, "
       "Chris Bass <dash@rd.bbc.co.uk>");
index 12a764e2848fe264b3cec020c6c6a075afed5cf2..571c0049117c0ac0f72baeb870591286adfecc32 100644 (file)
                     "GInitiallyUnowned",
                     "GObject"
                 ],
-                "klass": "Codec/Parser/Subtitle",
+                "klass": "Codec/Decoder/Subtitle",
                 "long-name": "SSA Subtitle Parser",
                 "pad-templates": {
                     "sink": {
                     "GInitiallyUnowned",
                     "GObject"
                 ],
-                "klass": "Codec/Parser/Subtitle",
+                "klass": "Codec/Decoder/Subtitle",
                 "long-name": "Subtitle parser",
                 "pad-templates": {
                     "sink": {
index d6fdb9c9fc91bfd88d438afdba98a6674a2788ec..42fbb42b99fee95589c7befb254e87e49ac08955 100644 (file)
@@ -108,7 +108,7 @@ gst_ssa_parse_class_init (GstSsaParseClass * klass)
   gst_element_class_add_static_pad_template (element_class, &sink_templ);
   gst_element_class_add_static_pad_template (element_class, &src_templ);
   gst_element_class_set_static_metadata (element_class,
-      "SSA Subtitle Parser", "Codec/Parser/Subtitle",
+      "SSA Subtitle Parser", "Codec/Decoder/Subtitle",
       "Parses SSA subtitle streams",
       "Tim-Philipp Müller <tim centricular net>");
 
index 2b69595e5cb29fbfc0ee39ec32089cfefeaf5309..994cf62d1acc50f60a7564cb39a22441d1032413 100644 (file)
@@ -137,7 +137,7 @@ gst_sub_parse_class_init (GstSubParseClass * klass)
   gst_element_class_add_static_pad_template (element_class, &sink_templ);
   gst_element_class_add_static_pad_template (element_class, &src_templ);
   gst_element_class_set_static_metadata (element_class,
-      "Subtitle parser", "Codec/Parser/Subtitle",
+      "Subtitle parser", "Codec/Decoder/Subtitle",
       "Parses subtitle (.sub) files into text streams",
       "Gustavo J. A. M. Carneiro <gjc@inescporto.pt>, "
       "GStreamer maintainers <gstreamer-devel@lists.freedesktop.org>");