mt76: mt7615: release mutex in mt7615_reset_test_set
authorLorenzo Bianconi <lorenzo@kernel.org>
Sat, 8 Aug 2020 18:25:41 +0000 (20:25 +0200)
committerFelix Fietkau <nbd@nbd.name>
Thu, 24 Sep 2020 16:10:15 +0000 (18:10 +0200)
Reduce scope of mutex_acquire/mutex_release in mt7615_reset_test_set
routine in order to fix the following static checker warning:

drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c:179
mt7615_reset_test_set()
warn: inconsistent returns 'dev->mt76.mutex'.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: ea4906c4be49 ("mt76: mt7615: wake device before accessing regmap in debugfs")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/debugfs.c

index 8893165..937cb71 100644 (file)
@@ -165,15 +165,14 @@ mt7615_reset_test_set(void *data, u64 val)
        if (!mt7615_wait_for_mcu_init(dev))
                return 0;
 
-       mt7615_mutex_acquire(dev);
-
        skb = alloc_skb(1, GFP_KERNEL);
        if (!skb)
                return -ENOMEM;
 
        skb_put(skb, 1);
-       mt76_tx_queue_skb_raw(dev, 0, skb, 0);
 
+       mt7615_mutex_acquire(dev);
+       mt76_tx_queue_skb_raw(dev, 0, skb, 0);
        mt7615_mutex_release(dev);
 
        return 0;