netdevsim: fix ptr_ret.cocci warnings
authorkbuild test robot <lkp@intel.com>
Tue, 4 Feb 2020 14:22:02 +0000 (22:22 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Feb 2020 12:55:32 +0000 (13:55 +0100)
drivers/net/netdevsim/dev.c:937:1-3: WARNING: PTR_ERR_OR_ZERO can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 6556ff32f12d ("netdevsim: use IS_ERR instead of IS_ERR_OR_NULL for debugfs")
CC: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netdevsim/dev.c

index 5c5427c..d7706a0 100644 (file)
@@ -934,9 +934,7 @@ int nsim_dev_port_del(struct nsim_bus_dev *nsim_bus_dev,
 int nsim_dev_init(void)
 {
        nsim_dev_ddir = debugfs_create_dir(DRV_NAME, NULL);
-       if (IS_ERR(nsim_dev_ddir))
-               return PTR_ERR(nsim_dev_ddir);
-       return 0;
+       return PTR_ERR_OR_ZERO(nsim_dev_ddir);
 }
 
 void nsim_dev_exit(void)