super: move lockdep assert

Fix braino and move the lockdep assertion after put_super() otherwise we
risk a use-after-free.

Fixes: 2c18a63b760a ("super: wait until we passed kill super")
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Message-Id: <20230828-vfs-super-fixes-v1-1-b37a4a04a88f@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>

diff --git a/fs/super.c b/fs/super.c
index ef87103e2a5197b1d4ffe882948d4f86f6752694..779247eb219cb6c25c1493db08e9df0e6c59aa34 100644 (file)
--- a/fs/super.c
+++ b/fs/super.c
@@ -570,8 +570,8 @@ static bool grab_super_dead(struct super_block *sb)
                return true;
        }
        wait_var_event(&sb->s_flags, wait_dead(sb));
-       put_super(sb);
        lockdep_assert_not_held(&sb->s_umount);
+       put_super(sb);
        return false;
 }