Rename VulkanViewer to Viewer, take 2.
authorjvanverth <jvanverth@google.com>
Wed, 4 May 2016 20:49:13 +0000 (13:49 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 4 May 2016 20:49:13 +0000 (13:49 -0700)
Also puts Window and Application in sk_app namespace.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1945103003

Review-Url: https://codereview.chromium.org/1945103003

31 files changed:
gyp/most.gyp
gyp/viewer.gyp [moved from gyp/vulkanviewer.gyp with 94% similarity]
platform_tools/android/apps/settings.gradle
platform_tools/android/apps/viewer/build.gradle [moved from platform_tools/android/apps/vulkanviewer/build.gradle with 89% similarity]
platform_tools/android/apps/viewer/src/main/AndroidManifest.xml [moved from platform_tools/android/apps/vulkanviewer/src/main/AndroidManifest.xml with 75% similarity]
platform_tools/android/apps/viewer/src/main/java/org/skia/viewer/ViewerActivity.java [moved from platform_tools/android/apps/vulkanviewer/src/main/java/org/skia/vulkanviewer/VulkanViewerActivity.java with 84% similarity]
platform_tools/android/gyp/skia_android.gypi
platform_tools/android/gyp/viewer.gypi [new file with mode: 0644]
platform_tools/android/gyp/vulkanviewer.gypi [deleted file]
tools/viewer/Application.h [moved from tools/vulkan/Application.h with 89% similarity]
tools/viewer/VulkanTestContext.cpp [moved from tools/vulkan/VulkanTestContext.cpp with 100% similarity]
tools/viewer/VulkanTestContext.h [moved from tools/vulkan/VulkanTestContext.h with 100% similarity]
tools/viewer/Window.cpp [moved from tools/vulkan/Window.cpp with 97% similarity]
tools/viewer/Window.h [moved from tools/vulkan/Window.h with 98% similarity]
tools/viewer/android/VulkanTestContext_android.cpp [moved from tools/vulkan/android/VulkanTestContext_android.cpp with 100% similarity]
tools/viewer/android/VulkanTestContext_android.h [moved from tools/vulkan/android/VulkanTestContext_android.h with 100% similarity]
tools/viewer/android/Window_android.cpp [moved from tools/vulkan/android/Window_android.cpp with 97% similarity]
tools/viewer/android/Window_android.h [moved from tools/vulkan/android/Window_android.h with 96% similarity]
tools/viewer/android/main_android.cpp [moved from tools/vulkan/android/main_android.cpp with 97% similarity]
tools/viewer/viewer/GMSlide.cpp [moved from tools/vulkan/viewer/GMSlide.cpp with 100% similarity]
tools/viewer/viewer/GMSlide.h [moved from tools/vulkan/viewer/GMSlide.h with 100% similarity]
tools/viewer/viewer/SKPSlide.cpp [moved from tools/vulkan/viewer/SKPSlide.cpp with 100% similarity]
tools/viewer/viewer/SKPSlide.h [moved from tools/vulkan/viewer/SKPSlide.h with 100% similarity]
tools/viewer/viewer/Slide.h [moved from tools/vulkan/viewer/Slide.h with 100% similarity]
tools/viewer/viewer/Viewer.cpp [moved from tools/vulkan/viewer/VulkanViewer.cpp with 91% similarity]
tools/viewer/viewer/Viewer.h [moved from tools/vulkan/viewer/VulkanViewer.h with 79% similarity]
tools/viewer/win/VulkanTestContext_win.cpp [moved from tools/vulkan/win/VulkanTestContext_win.cpp with 100% similarity]
tools/viewer/win/VulkanTestContext_win.h [moved from tools/vulkan/win/VulkanTestContext_win.h with 100% similarity]
tools/viewer/win/Window_win.cpp [moved from tools/vulkan/win/Window_win.cpp with 99% similarity]
tools/viewer/win/Window_win.h [moved from tools/vulkan/win/Window_win.h with 93% similarity]
tools/viewer/win/main_win.cpp [moved from tools/vulkan/win/main_win.cpp with 98% similarity]

index f0b56d6..6d56f88 100644 (file)
         'visualbench.gyp:visualbench',
         'fuzz.gyp:fuzz',
         'kilobench.gyp:kilobench',
-        'vulkanviewer.gyp:vulkanviewer',
+        'viewer.gyp:viewer',
       ],
       'conditions': [
         [ 'skia_gpu == 0', {
           'dependencies!': [
             'visualbench.gyp:visualbench',
             'kilobench.gyp:kilobench',
-            'vulkanviewer.gyp:vulkanviewer',
+            'viewer.gyp:viewer',
           ]
         }],
         [ 'skia_os != "android" and skia_os != "linux"', {
@@ -61,7 +61,7 @@
             }],
             [ 'skia_vulkan == 1', {
               'dependencies': [
-                'android_system.gyp:VulkanViewer_APK',
+                'android_system.gyp:Viewer_APK',
               ],
             }],
           ],
@@ -86,7 +86,7 @@
         }],
         [ 'skia_vulkan == 0 or (skia_os != "win" and skia_os != "android")', {
           'dependencies!': [
-            'vulkanviewer.gyp:vulkanviewer',
+            'viewer.gyp:viewer',
           ],
         }],
         [ 'skia_skip_gui',
similarity index 94%
rename from gyp/vulkanviewer.gyp
rename to gyp/viewer.gyp
index 91c175b..d8082ef 100644 (file)
@@ -10,7 +10,7 @@
   ],
   'targets': [
     {
-      'target_name': 'vulkanviewer',
+      'target_name': 'viewer',
       'type': 'executable',
       'includes' : [
         'gmslides.gypi',
@@ -28,7 +28,7 @@
       ],
       'sources': [
         '../gm/gm.cpp',
-        '<!@(python find.py ../tools/vulkan "*.cpp")',
+        '<!@(python find.py ../tools/viewer "*.cpp")',
       ],
       'dependencies': [
         'flags.gyp:flags',
index 9d103b4..d462ca8 100644 (file)
@@ -2,4 +2,4 @@ include ':sample_app'
 include ':visualbench'
 include ':visualbenchsdl'
 include ':canvasproof'
-include ':vulkanviewer'
+include ':viewer'
@@ -9,7 +9,7 @@ android {
     compileSdkVersion 19
     buildToolsVersion "22.0.1"
     defaultConfig {
-        applicationId "org.skia.vulkanviewer"
+        applicationId "org.skia.viewer"
         minSdkVersion 19
         targetSdkVersion 19
         versionCode 1
@@ -20,5 +20,5 @@ android {
     sourceSets.main.jniLibs.srcDir "src/main/libs"
     productFlavors { arm {}; arm64 {}; x86 {}; x86_64 {}; mips {}; mips64 {}; }
 
-    setupSkiaLibraryBuild(project, applicationVariants, "--vulkan CopyVulkanViewerDeps", true)
+    setupSkiaLibraryBuild(project, applicationVariants, "--vulkan CopyViewerDeps", true)
 }
@@ -1,20 +1,20 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- BEGIN_INCLUDE(manifest) -->
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-          package="org.skia.vulkanviewer"
+          package="org.skia.viewer"
           android:versionCode="1"
           android:versionName="1.0">
 
   <application
       android:allowBackup="false"
-      android:label="VulkanViewer">
+      android:label="Viewer">
 
-    <activity android:name=".VulkanViewerActivity"
-              android:label="VulkanViewer"
+    <activity android:name=".ViewerActivity"
+              android:label="Viewer"
               android:screenOrientation="portrait"
               android:configChanges="orientation|keyboardHidden">
       <meta-data android:name="android.app.lib_name"
-                 android:value="vulkanviewer" />
+                 android:value="viewer" />
       <intent-filter>
         <action android:name="android.intent.action.MAIN" />
         <category android:name="android.intent.category.LAUNCHER" />
@@ -5,7 +5,7 @@
  * found in the LICENSE file.
  */
 
-package org.skia.vulkanviewer;
+package org.skia.viewer;
 
 import android.app.ActionBar;
 import android.os.Bundle;
@@ -13,7 +13,7 @@ import android.provider.Settings;
 import android.view.View;
 import android.view.WindowManager;
 
-public class VulkanViewerActivity extends android.app.NativeActivity {
+public class ViewerActivity extends android.app.NativeActivity {
     static {
         System.loadLibrary("skia_android");
     }
index 29342d9..844bd6e 100644 (file)
@@ -49,7 +49,7 @@
   },
   'includes' : [
       'canvasproof.gypi',
-      'vulkanviewer.gypi',
+      'viewer.gypi',
   ],
   'targets': [
     {
diff --git a/platform_tools/android/gyp/viewer.gypi b/platform_tools/android/gyp/viewer.gypi
new file mode 100644 (file)
index 0000000..6d2659b
--- /dev/null
@@ -0,0 +1,65 @@
+# Copyright 2015 Google Inc.
+#
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+{
+  'targets': [
+    {
+      'target_name': 'CopyViewerDeps',
+      'type': 'none',
+      'dependencies': [
+        'skia_lib.gyp:skia_lib',
+        'viewer.gyp:viewer',
+      ],
+      'copies': [
+        {
+          'destination': '<(android_base)/apps/viewer/src/main/libs/<(android_arch)',
+          'conditions': [
+            [ 'skia_shared_lib', {
+              'files': [
+                '<(SHARED_LIB_DIR)/libskia_android.so',
+                '<(SHARED_LIB_DIR)/libviewer.so',
+              ]}, {
+              'files': [
+                '<(SHARED_LIB_DIR)/libviewer.so',
+              ]}
+           ],
+          ],
+        },
+      ],
+    },
+    {
+      'target_name': 'Viewer_APK',
+      'type': 'none',
+      'dependencies': [ 'CopyViewerDeps', ],
+      'actions': [
+        {
+          'action_name': 'SkiaViewer_apk',
+          'inputs': [
+            '<(android_base)/apps/viewer/src/main/AndroidManifest.xml',
+            '<(android_base)/apps/viewer/src/main/java/org/skia/viewer/ViewerActivity.java',
+            '<(android_base)/apps/viewer/src/main/libs/<(android_arch)/libviewer.so',
+
+          ],
+          'conditions': [
+            [ 'skia_shared_lib', {
+              'inputs': [
+                '<(android_base)/apps/viewer/src/main/libs/<(android_arch)/libskia_android.so',
+              ],
+            }],
+          ],
+          'outputs': [
+            '../apps/viewer/build/outputs/apk/',
+          ],
+          'action': [
+            '<(android_base)/apps/gradlew',
+            ':viewer:assemble<(android_variant)<(android_buildtype)',
+            '-p<(android_base)/apps/viewer',
+            '-PsuppressNativeBuild',
+            '--daemon',
+          ],
+        },
+      ],
+    },
+  ],
+}
diff --git a/platform_tools/android/gyp/vulkanviewer.gypi b/platform_tools/android/gyp/vulkanviewer.gypi
deleted file mode 100644 (file)
index b431e84..0000000
+++ /dev/null
@@ -1,65 +0,0 @@
-# Copyright 2015 Google Inc.
-#
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-{
-  'targets': [
-    {
-      'target_name': 'CopyVulkanViewerDeps',
-      'type': 'none',
-      'dependencies': [
-        'skia_lib.gyp:skia_lib',
-        'vulkanviewer.gyp:vulkanviewer',
-      ],
-      'copies': [
-        {
-          'destination': '<(android_base)/apps/vulkanviewer/src/main/libs/<(android_arch)',
-          'conditions': [
-            [ 'skia_shared_lib', {
-              'files': [
-                '<(SHARED_LIB_DIR)/libskia_android.so',
-                '<(SHARED_LIB_DIR)/libvulkanviewer.so',
-              ]}, {
-              'files': [
-                '<(SHARED_LIB_DIR)/libvulkanviewer.so',
-              ]}
-           ],
-          ],
-        },
-      ],
-    },
-    {
-      'target_name': 'VulkanViewer_APK',
-      'type': 'none',
-      'dependencies': [ 'CopyVulkanViewerDeps', ],
-      'actions': [
-        {
-          'action_name': 'SkiaVulkanViewer_apk',
-          'inputs': [
-            '<(android_base)/apps/vulkanviewer/src/main/AndroidManifest.xml',
-            '<(android_base)/apps/vulkanviewer/src/main/java/com/skia/vulkanviewer/VulkanViewerActivity.java',
-            '<(android_base)/apps/vulkanviewer/src/main/libs/<(android_arch)/libvulkanviewer.so',
-
-          ],
-          'conditions': [
-            [ 'skia_shared_lib', {
-              'inputs': [
-                '<(android_base)/apps/vulkanviewer/src/main/libs/<(android_arch)/libskia_android.so',
-              ],
-            }],
-          ],
-          'outputs': [
-            '../apps/vulkanviewer/build/outputs/apk/',
-          ],
-          'action': [
-            '<(android_base)/apps/gradlew',
-            ':vulkanviewer:assemble<(android_variant)<(android_buildtype)',
-            '-p<(android_base)/apps/vulkanviewer',
-            '-PsuppressNativeBuild',
-            '--daemon',
-          ],
-        },
-      ],
-    },
-  ],
-}
similarity index 89%
rename from tools/vulkan/Application.h
rename to tools/viewer/Application.h
index 4504d17..235ff09 100644 (file)
@@ -8,6 +8,8 @@
 #ifndef Application_DEFINED
 #define Application_DEFINED
 
+namespace sk_app {
+
 class Application {
 public:
     static Application* Create(int argc, char** argv, void* platformData);
@@ -17,4 +19,6 @@ public:
     virtual void onIdle(double ms) = 0;
 };
 
+}   // namespace sk_app
+
 #endif
similarity index 97%
rename from tools/vulkan/Window.cpp
rename to tools/viewer/Window.cpp
index 9042a0c..6a83a3b 100644 (file)
@@ -11,6 +11,8 @@
 #include "SkCanvas.h"
 #include "VulkanTestContext.h"
 
+namespace sk_app {
+
 static bool default_char_func(SkUnichar c, uint32_t modifiers, void* userData) {
     return false;
 }
@@ -72,3 +74,5 @@ void Window::onResize(uint32_t w, uint32_t h) {
     fHeight = h;
     fTestContext->resize(w, h);
 }
+
+}   // namespace sk_app
similarity index 98%
rename from tools/vulkan/Window.h
rename to tools/viewer/Window.h
index 714d8df..913d2da 100644 (file)
@@ -14,6 +14,8 @@
 class SkCanvas;
 class VulkanTestContext;
 
+namespace sk_app {
+
 class Window {
 public:
     static Window* CreateNativeWindow(void* platformData);
@@ -144,5 +146,5 @@ protected:
     VulkanTestContext* fTestContext;
 };
 
-
+}   // namespace sk_app
 #endif
similarity index 97%
rename from tools/vulkan/android/Window_android.cpp
rename to tools/viewer/android/Window_android.cpp
index 87a4d22..ebccb8b 100644 (file)
@@ -9,6 +9,8 @@
 
 #include "VulkanTestContext_android.h"
 
+namespace sk_app {
+
 Window* Window::CreateNativeWindow(void* platformData) {
     Window_android* window = new Window_android();
     if (!window->init((android_app*)platformData)) {
@@ -61,7 +63,7 @@ static void android_app_write_cmd(struct android_app* android_app, int8_t cmd) {
 }
 
 void Window_android::inval() {
-       android_app_write_cmd(mApp, APP_CMD_INVAL_WINDOW);
+    android_app_write_cmd(mApp, APP_CMD_INVAL_WINDOW);
 }
 
 void Window_android::paintIfNeeded() {
@@ -149,7 +151,7 @@ static int32_t get_key_modifiers(AInputEvent* event) {
     int32_t modifiers = 0;
 
     if (AKeyEvent_getRepeatCount(event) == 0) {
-       modifiers |= Window::kFirstPress_ModifierKey;
+        modifiers |= Window::kFirstPress_ModifierKey;
     }
 
     for (size_t i = 0; i < SK_ARRAY_COUNT(gPair); i++) {
@@ -177,3 +179,5 @@ static int32_t handle_input(struct android_app* app, AInputEvent* event) {
     }
     return 0;
 }
+
+}   // namespace sk_app
similarity index 96%
rename from tools/vulkan/android/Window_android.h
rename to tools/viewer/android/Window_android.h
index fa675fe..6099f89 100644 (file)
@@ -11,6 +11,8 @@
 #include "../Window.h"
 #include <android_native_app_glue.h>
 
+namespace sk_app {
+
 enum {
     /**
      * Leave plenty of space between this item and the ones defined in the glue layer
@@ -45,4 +47,6 @@ private:
     int mSampleCount = 0;
 };
 
+}   // namespace sk_app
+
 #endif
similarity index 97%
rename from tools/vulkan/android/main_android.cpp
rename to tools/viewer/android/main_android.cpp
index 783cd1f..9334f0c 100644 (file)
@@ -15,6 +15,8 @@
 
 static double now_ms() { return SkTime::GetNSecs() * 1e-6; }
 
+using sk_app::Application;
+
 /**
  * This is the main entry point of a native application that is using
  * android_native_app_glue.  It runs in its own thread, with its own
@@ -25,7 +27,7 @@ void android_main(struct android_app* state) {
     app_dummy();
 
     static const char* gCmdLine[] = {
-        "vulkanviewer",
+        "viewer",
         "--skps",
         "/data/local/tmp/skp",
     };
similarity index 91%
rename from tools/vulkan/viewer/VulkanViewer.cpp
rename to tools/viewer/viewer/Viewer.cpp
index 79c4968..ededc1f 100644 (file)
@@ -5,7 +5,7 @@
 * found in the LICENSE file.
 */
 
-#include "VulkanViewer.h"
+#include "Viewer.h"
 
 #include "GMSlide.h"
 #include "SKPSlide.h"
 #include "SkRandom.h"
 #include "SkStream.h"
 
+using namespace sk_app;
+
 Application* Application::Create(int argc, char** argv, void* platformData) {
-    return new VulkanViewer(argc, argv, platformData);
+    return new Viewer(argc, argv, platformData);
 }
 
 static bool on_key_handler(Window::Key key, Window::InputState state, uint32_t modifiers,
                            void* userData) {
-    VulkanViewer* vv = reinterpret_cast<VulkanViewer*>(userData);
+    Viewer* vv = reinterpret_cast<Viewer*>(userData);
 
     return vv->onKey(key, state, modifiers);
 }
 
 static bool on_char_handler(SkUnichar c, uint32_t modifiers, void* userData) {
-    VulkanViewer* vv = reinterpret_cast<VulkanViewer*>(userData);
+    Viewer* vv = reinterpret_cast<Viewer*>(userData);
 
     return vv->onChar(c, modifiers);
 }
 
 static void on_paint_handler(SkCanvas* canvas, void* userData) {
-    VulkanViewer* vv = reinterpret_cast<VulkanViewer*>(userData);
+    Viewer* vv = reinterpret_cast<Viewer*>(userData);
 
     return vv->onPaint(canvas);
 }
@@ -52,7 +54,7 @@ DEFINE_string2(match, m, nullptr,
                "it is skipped unless some list entry starts with ~");
 DEFINE_string(skps, "skps", "Directory to read skps from.");
 
-VulkanViewer::VulkanViewer(int argc, char** argv, void* platformData)
+Viewer::Viewer(int argc, char** argv, void* platformData)
     : fCurrentMeasurement(0)
     , fDisplayStats(false)
     , fZoomCenterX(0.0f)
@@ -91,7 +93,7 @@ VulkanViewer::VulkanViewer(int argc, char** argv, void* platformData)
     fWindow->show();
 }
 
-void VulkanViewer::initSlides() {
+void Viewer::initSlides() {
     const skiagm::GMRegistry* gms(skiagm::GMRegistry::Head());
     while (gms) {
         SkAutoTDelete<skiagm::GM> gm(gms->factory()(nullptr));
@@ -142,13 +144,13 @@ void VulkanViewer::initSlides() {
 }
 
 
-VulkanViewer::~VulkanViewer() {
+Viewer::~Viewer() {
     fWindow->detach();
     delete fWindow;
 }
 
-void VulkanViewer::setupCurrentSlide(int previousSlide) {
-    SkString title("VulkanViewer: ");
+void Viewer::setupCurrentSlide(int previousSlide) {
+    SkString title("Viewer: ");
     title.append(fSlides[fCurrentSlide]->getName());
     fSlides[fCurrentSlide]->load();
     if (previousSlide >= 0) {
@@ -161,7 +163,7 @@ void VulkanViewer::setupCurrentSlide(int previousSlide) {
 #define MAX_ZOOM_LEVEL  8
 #define MIN_ZOOM_LEVEL  -8
 
-void VulkanViewer::changeZoomLevel(float delta) {
+void Viewer::changeZoomLevel(float delta) {
     fZoomLevel += delta;
     if (fZoomLevel > 0) {
         fZoomLevel = SkMinScalar(fZoomLevel, MAX_ZOOM_LEVEL);
@@ -175,7 +177,7 @@ void VulkanViewer::changeZoomLevel(float delta) {
     this->updateMatrix();
 }
 
-void VulkanViewer::updateMatrix(){
+void Viewer::updateMatrix(){
     SkMatrix m;
     m.reset();
 
@@ -199,7 +201,7 @@ void VulkanViewer::updateMatrix(){
     fLocalMatrix = m;
 }
 
-bool VulkanViewer::onKey(Window::Key key, Window::InputState state, uint32_t modifiers) {
+bool Viewer::onKey(Window::Key key, Window::InputState state, uint32_t modifiers) {
     if (Window::kDown_InputState == state) {
         switch (key) {
             case Window::kRight_Key: {
@@ -218,7 +220,7 @@ bool VulkanViewer::onKey(Window::Key key, Window::InputState state, uint32_t mod
                 if (fCurrentSlide < 0) {
                     fCurrentSlide = fSlides.count() - 1;
                 }
-                SkString title("VulkanViewer: ");
+                SkString title("Viewer: ");
                 title.append(fSlides[fCurrentSlide]->getName());
                 fWindow->setTitle(title.c_str());
                 setupCurrentSlide(previousSlide);
@@ -245,7 +247,7 @@ bool VulkanViewer::onKey(Window::Key key, Window::InputState state, uint32_t mod
     return false;
 }
 
-bool VulkanViewer::onChar(SkUnichar c, uint32_t modifiers) {
+bool Viewer::onChar(SkUnichar c, uint32_t modifiers) {
     if ('s' == c) {
         fDisplayStats = !fDisplayStats;
         return true;
@@ -254,7 +256,7 @@ bool VulkanViewer::onChar(SkUnichar c, uint32_t modifiers) {
     return false;
 }
 
-void VulkanViewer::onPaint(SkCanvas* canvas) {
+void Viewer::onPaint(SkCanvas* canvas) {
 
     int count = canvas->save();
 
@@ -283,7 +285,7 @@ void VulkanViewer::onPaint(SkCanvas* canvas) {
     }
 }
 
-void VulkanViewer::drawStats(SkCanvas* canvas) {
+void Viewer::drawStats(SkCanvas* canvas) {
     static const float kPixelPerMS = 2.0f;
     static const int kDisplayWidth = 130;
     static const int kDisplayHeight = 100;
@@ -331,7 +333,7 @@ void VulkanViewer::drawStats(SkCanvas* canvas) {
     canvas->restore();
 }
 
-void VulkanViewer::onIdle(double ms) {
+void Viewer::onIdle(double ms) {
     // Record measurements
     fMeasurements[fCurrentMeasurement++] = ms;
     fCurrentMeasurement &= (kMeasurementCount - 1);  // fast mod
similarity index 79%
rename from tools/vulkan/viewer/VulkanViewer.h
rename to tools/viewer/viewer/Viewer.h
index 7e39f88..43d29ba 100644 (file)
@@ -5,8 +5,8 @@
 * found in the LICENSE file.
 */
 
-#ifndef VulkanViewer_DEFINED
-#define VulkanViewer_DEFINED
+#ifndef Viewer_DEFINED
+#define Viewer_DEFINED
 
 #include "../Application.h"
 #include "../Window.h"
 
 class SkCanvas;
 
-class VulkanViewer : public Application {
+class Viewer : public sk_app::Application {
 public:
-    VulkanViewer(int argc, char** argv, void* platformData);
-    ~VulkanViewer() override;
+    Viewer(int argc, char** argv, void* platformData);
+    ~Viewer() override;
 
-    bool onKey(Window::Key key, Window::InputState state, uint32_t modifiers);
+    bool onKey(sk_app::Window::Key key, sk_app::Window::InputState state, uint32_t modifiers);
     bool onChar(SkUnichar, uint32_t modifiers);
     void onPaint(SkCanvas* canvas);
     void onIdle(double ms) override;
@@ -35,7 +35,7 @@ private:
     void changeZoomLevel(float delta);
     void updateMatrix();
 
-    Window*      fWindow;
+    sk_app::Window*        fWindow;
 
     static const int kMeasurementCount = 64;  // should be power of 2 for fast mod
     double fMeasurements[kMeasurementCount];
similarity index 99%
rename from tools/vulkan/win/Window_win.cpp
rename to tools/viewer/win/Window_win.cpp
index 58224d6..d5711b7 100644 (file)
@@ -14,6 +14,8 @@
 #include "SkUtils.h"
 #include "VulkanTestContext_win.h"
 
+namespace sk_app {
+
 Window* Window::CreateNativeWindow(void* platformData) {
     HINSTANCE hInstance = (HINSTANCE)platformData;
 
@@ -279,3 +281,5 @@ bool Window_win::attach(BackEndType attachType, int msaaSampleCount) {
 void Window_win::inval() {
     InvalidateRect(fHWnd, nullptr, false);
 }
+
+}   // namespace sk_app
similarity index 93%
rename from tools/vulkan/win/Window_win.h
rename to tools/viewer/win/Window_win.h
index 127fa13..e295212 100644 (file)
@@ -11,6 +11,8 @@
 #include <windows.h>
 #include "../Window.h"
 
+namespace sk_app {
+
 class Window_win : public Window {
 public:
     Window_win() : Window() {}
@@ -30,4 +32,6 @@ private:
     HWND      fHWnd;
 };
 
+}   // namespace sk_app
+
 #endif
similarity index 98%
rename from tools/vulkan/win/main_win.cpp
rename to tools/viewer/win/main_win.cpp
index c2ad6da..ba1629c 100644 (file)
@@ -13,6 +13,8 @@
 #include "Window_win.h"
 #include "../Application.h"
 
+using sk_app::Application;
+
 static char* tchar_to_utf8(const TCHAR* str) {
 #ifdef _UNICODE
     int size = WideCharToMultiByte(CP_UTF8, 0, str, wcslen(str), NULL, 0, NULL, NULL);